From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752103AbbEAUZG (ORCPT <rfc822;w@1wt.eu>);
	Fri, 1 May 2015 16:25:06 -0400
Received: from down.free-electrons.com ([37.187.137.238]:53094 "EHLO
	mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1750804AbbEAUZD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 1 May 2015 16:25:03 -0400
Date: Fri, 1 May 2015 22:22:18 +0200
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Michal Suchanek <hramrach@gmail.com>
Cc: linux-sunxi@googlegroups.com, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] ARM: dts: sunxi: sun5i: add spi2_pins_b.
Message-ID: <20150501202218.GK6062@lukather>
References: <cover.1430295711.git.hramrach@gmail.com>
 <bda468ecf45ca063098f756bdaba85b6f5f42263.1430295711.git.hramrach@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="8tUgZ4IE8L4vmMyh"
Content-Disposition: inline
In-Reply-To: <bda468ecf45ca063098f756bdaba85b6f5f42263.1430295711.git.hramrach@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--8tUgZ4IE8L4vmMyh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 29, 2015 at 10:00:27AM +0200, Michal Suchanek wrote:
> spi2_pins_a are only available on A10s

spi2_pins_a doesn't mean anything without any context.

Anyone should be able to read this commit log alone and understand
what it's about and why you are doing it.

It's clearly not the case here.

>=20
> Signed-off-by: Michal Suchanek <hramrach@gmail.com>
> ---
>  arch/arm/boot/dts/sun5i.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
>=20
> diff --git a/arch/arm/boot/dts/sun5i.dtsi b/arch/arm/boot/dts/sun5i.dtsi
> index 186d25f..9f22c28 100644
> --- a/arch/arm/boot/dts/sun5i.dtsi
> +++ b/arch/arm/boot/dts/sun5i.dtsi
> @@ -551,6 +551,13 @@
>  				allwinner,drive =3D <SUN4I_PINCTRL_30_MA>;
>  				allwinner,pull =3D <SUN4I_PINCTRL_PULL_UP>;
>  			};
> +
> +			spi2_pins_b: spi2@1 {

You should probably name that group spi2_pins_a. It feels a bit weird
to have a spi2_pins_b group without its "a" counterpart.

Maxime

--=20
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

--8tUgZ4IE8L4vmMyh
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVQ+B6AAoJEBx+YmzsjxAgBs8P/jn8160u4DcQ8v4katPxks4c
2chM3HJtFLaqMoeNU+aFile+paW2X63pu9UJA5b15tL1FeARawWCZZBUzYCkcXAy
8bZZPAiVZURVGcM7OB3mgonR3ZrpzXB3F28OoWIH858NrKXx+pB7dQ/7V6D/orQP
E6tGk4kwLC2tuKOd1BQtS/zjBA9kz7iZB5NJPUO2ORexWP2uwtuU2QZ+dCDchLwc
1mW/K57W1zddKixlsO+KwmK+recpnS6ladF3XmNplSX/2T2tWb6DjgmxzTLNArYW
UnWo/d8U/TGdaD7faSYa5iGbtyVUlEb4GSDBCoOgCaSdW7hZe6rKbqZa1o8+hgDf
Q/wDBPDFB0PFZE5llyy4GCXZ/+7jFhT89L7RVSFluyUltj+REISnfhgqLxK5mply
k8sZkNyr9bL8M89Ey3NX7HRvqcGHDkBDU3po6TzQ4obCX8+nyJHVoYqT28HkPIZ1
eGbHn1iNhQGhHmat3W8IPmqV734Q/AL5Sh9p6zyPs1lfeKnbKqF6qCbrK0QWXMzd
3Vh63iNFwirPPtL5ZWLXj7/1qznVjaMRcPDO3825w65eeEykD6KsxpdeoJl/ixLG
iEvae1gTEjTkiZw3Yg+yMzCn2WUwvw+HPkHaqWcERAnhDPFntTAsARk6p2rP09Vr
qRfUt0vT1BSf5Ras3NYy
=/hlZ
-----END PGP SIGNATURE-----

--8tUgZ4IE8L4vmMyh--