public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Guenter Roeck <linux@roeck-us.net>,
	Jean Delvare <jdelvare@suse.de>,
	Fenghua Yu <fenghua.yu@intel.com>,
	Benoit Cousson <bcousson@baylibre.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 5/6] x86: replace cpu_**_mask() with topology_**_cpumask()
Date: Sat, 2 May 2015 08:33:55 +0200	[thread overview]
Message-ID: <20150502063355.GA25303@gmail.com> (raw)
In-Reply-To: <1430388241-4502-6-git-send-email-bgolaszewski@baylibre.com>


* Bartosz Golaszewski <bgolaszewski@baylibre.com> wrote:

> The former duplicate the functionalities of the latter but are neither
> documented nor arch-independent.

>  	if (!has_mp) {
> -		cpumask_set_cpu(cpu, cpu_sibling_mask(cpu));
> +		cpumask_set_cpu(cpu, topology_thread_cpumask(cpu));
>  		cpumask_set_cpu(cpu, cpu_llc_shared_mask(cpu));

So why does topology.h invent a new name for 'sibling CPUs'?

At least in the scheduling context, 'sibling' is the term we are using 
in most places in the scheduler - try 'git grep sibling kernel/sched/'.

'thread' is a bad name anyway for a CPU, even if we didn't have an 
existing term for it.

So please rename topology_thread_cpumask to topology_sibling_cpumask 
to not replace one inconsistency for another one ...

Thanks,

	Ingo

  reply	other threads:[~2015-05-02  6:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-30 10:03 [PATCH 0/6] x86: remove cpu_**_mask() functions Bartosz Golaszewski
2015-04-30 10:03 ` [PATCH 1/6] coretemp: replace cpu_sibling_mask() with topology_thread_cpumask() Bartosz Golaszewski
2015-04-30 13:10   ` Guenter Roeck
2015-04-30 10:03 ` [PATCH 2/6] powernow-k8: replace cpu_core_mask() with topology_core_cpumask() Bartosz Golaszewski
2015-04-30 10:03 ` [PATCH 3/6] p4-clockmod: replace cpu_sibling_mask() with topology_thread_cpumask() Bartosz Golaszewski
2015-04-30 10:03 ` [PATCH 4/6] acpi-cpufreq: replace cpu_**_mask() with topology_**_cpumask() Bartosz Golaszewski
2015-04-30 10:04 ` [PATCH 5/6] x86: " Bartosz Golaszewski
2015-05-02  6:33   ` Ingo Molnar [this message]
2015-05-04  8:23     ` Bartosz Golaszewski
2015-04-30 10:04 ` [PATCH 6/6] x86: remove cpu_sibling_mask() and cpu_core_mask() Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150502063355.GA25303@gmail.com \
    --to=mingo@kernel.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=bcousson@baylibre.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=fenghua.yu@intel.com \
    --cc=hpa@zytor.com \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=mingo@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=viresh.kumar@linaro.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox