From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
torvalds@linux-foundation.org, akpm@linux-foundation.org,
linux@roeck-us.net, shuah.kh@samsung.com, stable@vger.kernel.org
Subject: [PATCH 3.10 00/65] 3.10.77-stable review
Date: Sat, 2 May 2015 21:03:30 +0200 [thread overview]
Message-ID: <20150502190114.555225285@linuxfoundation.org> (raw)
This is the start of the stable review cycle for the 3.10.77 release.
There are 65 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Mon May 4 19:00:04 UTC 2015.
Anything received after that time might be too late.
The whole patch series can be found in one patch at:
kernel.org/pub/linux/kernel/v3.0/stable-review/patch-3.10.77-rc1.gz
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Linux 3.10.77-rc1
Dan Carpenter <dan.carpenter@oracle.com>
memstick: mspro_block: add missing curly braces
Nishanth Menon <nm@ti.com>
C6x: time: Ensure consistency in __init
Nicolas Iooss <nicolas.iooss_linux@m4x.org>
wl18xx: show rx_frames_per_rates as an array as it really is
mancha security <mancha1@zoho.com>
lib: memzero_explicit: use barrier instead of OPTIMIZER_HIDE_VAR
Sabrina Dubroca <sd@queasysnail.net>
e1000: add dummy allocator to fix race condition between mtu change and netpoll
Calvin Owens <calvinowens@fb.com>
ksoftirqd: Enable IRQs and call cond_resched() before poking RCU
Al Viro <viro@zeniv.linux.org.uk>
RCU pathwalk breakage when running into a symlink overmounting something
Dmitry Torokhov <dmitry.torokhov@gmail.com>
drm/i915: cope with large i2c transfers
Alex Deucher <alexander.deucher@amd.com>
drm/radeon: fix doublescan modes (v2)
Mark Brown <broonie@kernel.org>
i2c: core: Export bus recovery functions
Rabin Vincent <rabin@rab.in>
tracing: Handle ftrace_dump() atomic context in graph_trace_open()
Erez Shitrit <erezsh@mellanox.com>
IB/mlx4: Fix WQE LSO segment calculation
Yann Droneaud <ydroneaud@opteya.com>
IB/core: don't disallow registering region starting at 0x0
Yann Droneaud <ydroneaud@opteya.com>
IB/core: disallow registering 0-sized memory region
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
stk1160: Make sure current buffer is released
James Bottomley <JBottomley@Odin.com>
mvsas: fix panic on expander attached SATA devices
K. Y. Srinivasan <kys@microsoft.com>
Drivers: hv: vmbus: Fix a bug in the error path in vmbus_open()
Gregory CLEMENT <gregory.clement@free-electrons.com>
gpio: mvebu: Fix mask/unmask managment per irq chip type
Max Filippov <jcmvbkbc@gmail.com>
xtensa: provide __NR_sync_file_range2 instead of __NR_sync_file_range
Max Filippov <jcmvbkbc@gmail.com>
xtensa: xtfpga: fix hardware lockup caused by LCD driver
Lv Zheng <lv.zheng@intel.com>
ACPICA: Utilities: split IO address types from data type models.
Guenter Roeck <linux@roeck-us.net>
drivers: parport: Kconfig: exclude arm64 for PARPORT_PC
K. Y. Srinivasan <kys@microsoft.com>
scsi: storvsc: Fix a bug in copy_from_bounce_buffer()
Brian Norris <computersforpeace@gmail.com>
UBI: fix check for "too many bytes"
Brian Norris <computersforpeace@gmail.com>
UBI: initialize LEB number variable
Brian Norris <computersforpeace@gmail.com>
UBI: fix out of bounds write
Brian Norris <computersforpeace@gmail.com>
UBI: account for bitflips in both the VID header and data
Thomas D <whissi@whissi.de>
tools/power turbostat: Use $(CURDIR) instead of $(PWD) and add support for O= option in Makefile
Anton Blanchard <anton@samba.org>
powerpc/perf: Cap 64bit userspace backtraces to PERF_MAX_STACK_DEPTH
Lukas Czerner <lczerner@redhat.com>
ext4: make fsync to sync parent dir in no-journal for real this time
Chen Gang <gang.chen@asianux.com>
arm64: kernel: compiling issue, need delete read_current_timer()
Mark Brown <broonie@linaro.org>
video: vgacon: Don't build on arm64
Geert Uytterhoeven <geert@linux-m68k.org>
console: Disable VGA text console support on cris
Chen Gang <gang.chen@asianux.com>
drivers: parport: Kconfig: exclude h8300 for PARPORT_PC
Geert Uytterhoeven <geert@linux-m68k.org>
parport: disable PC-style parallel port support on cris
Marek Vasut <marex@denx.de>
rtlwifi: rtl8192cu: Add new device ID
Larry Finger <Larry.Finger@lwfinger.net>
rtlwifi: rtl8192cu: Add new USB ID
Oleg Nesterov <oleg@redhat.com>
ptrace: fix race between ptrace_resume() and wait_task_stopped()
Michael Davidson <md@google.com>
fs/binfmt_elf.c: fix bug in loading of PIE binaries
Ulrik De Bie <ulrik.debie-os@e2big.org>
Input: elantech - fix absolute mode setting on some ASUS laptops
Michael Gernoth <michael@gernoth.net>
ALSA: emu10k1: don't deadlock in proc-functions
Felipe Balbi <balbi@ti.com>
usb: core: hub: use new USB_RESUME_TIMEOUT
Felipe Balbi <balbi@ti.com>
usb: host: sl811: use new USB_RESUME_TIMEOUT
Felipe Balbi <balbi@ti.com>
usb: host: xhci: use new USB_RESUME_TIMEOUT
Felipe Balbi <balbi@ti.com>
usb: host: isp116x: use new USB_RESUME_TIMEOUT
Felipe Balbi <balbi@ti.com>
usb: host: r8a66597: use new USB_RESUME_TIMEOUT
Felipe Balbi <balbi@ti.com>
usb: define a generic USB_RESUME_TIMEOUT macro
Axel Lin <axel.lin@ingics.com>
usb: phy: Find the right match in devm_usb_phy_match
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
ARM: S3C64XX: Use fixed IRQ bases to avoid conflicts on Cragganmore
Andrey Ryabinin <a.ryabinin@samsung.com>
ARM: 8320/1: fix integer overflow in ELF_ET_DYN_BASE
Krzysztof Kozlowski <k.kozlowski@samsung.com>
power_supply: lp8788-charger: Fix leaked power supply on probe fail
Steven Rostedt <rostedt@goodmis.org>
ring-buffer: Replace this_cpu_*() with __this_cpu_*()
Ian Abbott <abbotti@mev.co.uk>
spi: spidev: fix possible arithmetic overflow for multi-transfer message
Oliver Neukum <oneukum@suse.de>
cdc-wdm: fix endianness bug in debug statements
Huacai Chen <chenhc@lemote.com>
MIPS: Hibernate: flush TLB entries earlier
Radim Krčmář <rkrcmar@redhat.com>
KVM: use slowpath for cross page cached accesses
Heiko Carstens <heiko.carstens@de.ibm.com>
s390/hibernate: fix save and restore of kernel text section
Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>
KVM: s390: Zero out current VMDB of STSI before including level3 data.
Felipe Balbi <balbi@ti.com>
usb: gadget: composite: enable BESL support
Len Brown <len.brown@intel.com>
sched/idle/x86: Restore mwait_idle() to fix boot hangs, to improve power savings and to improve performance
Filipe Manana <fdmanana@suse.com>
Btrfs: fix inode eviction infinite loop after cloning into it
Filipe Manana <fdmanana@suse.com>
Btrfs: fix log tree corruption when fs mounted with -o discard
Eric Dumazet <edumazet@google.com>
tcp: avoid looping in tcp_send_fin()
Eric Dumazet <edumazet@google.com>
tcp: fix possible deadlock in tcp_send_fin()
Sebastian Pöhn <sebastian.poehn@gmail.com>
ip_forward: Drop frames with attached skb->sk
-------------
Diffstat:
Makefile | 4 +-
arch/arm/include/asm/elf.h | 2 +-
arch/arm/mach-s3c64xx/crag6410.h | 1 +
arch/arm/mach-s3c64xx/mach-crag6410.c | 1 +
arch/arm64/include/asm/timex.h | 6 +-
arch/arm64/kernel/time.c | 6 --
arch/c6x/kernel/time.c | 2 +-
arch/mips/power/hibernate.S | 3 +-
arch/powerpc/perf/callchain.c | 2 +-
arch/s390/kernel/suspend.c | 4 ++
arch/s390/kvm/priv.c | 1 +
arch/x86/kernel/process.c | 49 ++++++++++++++++
arch/xtensa/Kconfig | 30 ++++++++++
arch/xtensa/include/uapi/asm/unistd.h | 2 +-
arch/xtensa/platforms/xtfpga/Makefile | 3 +-
.../platforms/xtfpga/include/platform/hardware.h | 3 -
.../xtensa/platforms/xtfpga/include/platform/lcd.h | 15 +++++
arch/xtensa/platforms/xtfpga/lcd.c | 55 +++++++++++-------
drivers/gpio/gpio-mvebu.c | 24 +++++---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_i2c.c | 66 ++++++++++++++++++----
drivers/gpu/drm/radeon/atombios_crtc.c | 8 ++-
drivers/hv/channel.c | 7 ++-
drivers/i2c/i2c-core.c | 3 +
drivers/infiniband/core/umem.c | 7 ++-
drivers/infiniband/hw/mlx4/qp.c | 3 +-
drivers/input/mouse/elantech.c | 22 ++++++++
drivers/input/mouse/elantech.h | 1 +
drivers/media/usb/stk1160/stk1160-v4l.c | 17 +++++-
drivers/memstick/core/mspro_block.c | 3 +-
drivers/mtd/ubi/attach.c | 2 +-
drivers/mtd/ubi/cdev.c | 2 +-
drivers/mtd/ubi/eba.c | 3 +-
drivers/mtd/ubi/wl.c | 2 +-
drivers/net/ethernet/intel/e1000/e1000_main.c | 10 +++-
drivers/net/wireless/rtlwifi/rtl8192cu/sw.c | 2 +
drivers/net/wireless/ti/wl18xx/debugfs.c | 2 +-
drivers/net/wireless/ti/wlcore/debugfs.h | 4 +-
drivers/parport/Kconfig | 4 +-
drivers/power/lp8788-charger.c | 4 +-
drivers/scsi/mvsas/mv_sas.c | 5 +-
drivers/scsi/storvsc_drv.c | 15 ++---
drivers/spi/spidev.c | 5 +-
drivers/usb/class/cdc-wdm.c | 12 ++--
drivers/usb/core/hub.c | 4 +-
drivers/usb/gadget/composite.c | 2 +-
drivers/usb/host/isp116x-hcd.c | 2 +-
drivers/usb/host/r8a66597-hcd.c | 2 +-
drivers/usb/host/sl811-hcd.c | 2 +-
drivers/usb/host/xhci-ring.c | 2 +-
drivers/usb/phy/phy.c | 4 +-
drivers/video/console/Kconfig | 5 +-
fs/binfmt_elf.c | 9 ++-
fs/btrfs/extent-tree.c | 5 +-
fs/btrfs/ioctl.c | 5 ++
fs/ext4/namei.c | 20 ++++---
fs/namei.c | 6 +-
include/acpi/actypes.h | 20 +++++++
include/acpi/platform/acenv.h | 1 +
include/linux/usb.h | 26 +++++++++
kernel/ptrace.c | 20 +++++++
kernel/softirq.c | 6 +-
kernel/trace/ring_buffer.c | 11 ++--
kernel/trace/trace_functions_graph.c | 8 ++-
lib/string.c | 2 +-
net/ipv4/ip_forward.c | 3 +
net/ipv4/tcp_output.c | 64 ++++++++++++++-------
sound/pci/emu10k1/emuproc.c | 12 ----
tools/power/x86/turbostat/Makefile | 6 +-
virt/kvm/kvm_main.c | 4 +-
70 files changed, 509 insertions(+), 165 deletions(-)
next reply other threads:[~2015-05-02 19:48 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 19:03 Greg Kroah-Hartman [this message]
2015-05-02 19:03 ` [PATCH 3.10 01/65] ip_forward: Drop frames with attached skb->sk Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 02/65] tcp: fix possible deadlock in tcp_send_fin() Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 03/65] tcp: avoid looping " Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 04/65] Btrfs: fix log tree corruption when fs mounted with -o discard Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 05/65] Btrfs: fix inode eviction infinite loop after cloning into it Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 06/65] sched/idle/x86: Restore mwait_idle() to fix boot hangs, to improve power savings and to improve performance Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 07/65] usb: gadget: composite: enable BESL support Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 08/65] KVM: s390: Zero out current VMDB of STSI before including level3 data Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 09/65] s390/hibernate: fix save and restore of kernel text section Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 11/65] MIPS: Hibernate: flush TLB entries earlier Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 12/65] cdc-wdm: fix endianness bug in debug statements Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 13/65] spi: spidev: fix possible arithmetic overflow for multi-transfer message Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 14/65] ring-buffer: Replace this_cpu_*() with __this_cpu_*() Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 15/65] power_supply: lp8788-charger: Fix leaked power supply on probe fail Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 16/65] ARM: 8320/1: fix integer overflow in ELF_ET_DYN_BASE Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 17/65] ARM: S3C64XX: Use fixed IRQ bases to avoid conflicts on Cragganmore Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 18/65] usb: phy: Find the right match in devm_usb_phy_match Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 19/65] usb: define a generic USB_RESUME_TIMEOUT macro Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 20/65] usb: host: r8a66597: use new USB_RESUME_TIMEOUT Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 21/65] usb: host: isp116x: " Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 22/65] usb: host: xhci: " Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 23/65] usb: host: sl811: " Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 24/65] usb: core: hub: " Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 25/65] ALSA: emu10k1: dont deadlock in proc-functions Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 26/65] Input: elantech - fix absolute mode setting on some ASUS laptops Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 27/65] fs/binfmt_elf.c: fix bug in loading of PIE binaries Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 28/65] ptrace: fix race between ptrace_resume() and wait_task_stopped() Greg Kroah-Hartman
2015-05-02 19:03 ` [PATCH 3.10 29/65] rtlwifi: rtl8192cu: Add new USB ID Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 30/65] rtlwifi: rtl8192cu: Add new device ID Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 31/65] parport: disable PC-style parallel port support on cris Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 32/65] drivers: parport: Kconfig: exclude h8300 for PARPORT_PC Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 33/65] console: Disable VGA text console support on cris Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 34/65] video: vgacon: Dont build on arm64 Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 35/65] arm64: kernel: compiling issue, need delete read_current_timer() Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 36/65] ext4: make fsync to sync parent dir in no-journal for real this time Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 37/65] powerpc/perf: Cap 64bit userspace backtraces to PERF_MAX_STACK_DEPTH Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 38/65] tools/power turbostat: Use $(CURDIR) instead of $(PWD) and add support for O= option in Makefile Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 39/65] UBI: account for bitflips in both the VID header and data Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 40/65] UBI: fix out of bounds write Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 41/65] UBI: initialize LEB number variable Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 42/65] UBI: fix check for "too many bytes" Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 43/65] scsi: storvsc: Fix a bug in copy_from_bounce_buffer() Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 44/65] drivers: parport: Kconfig: exclude arm64 for PARPORT_PC Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 45/65] ACPICA: Utilities: split IO address types from data type models Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 46/65] xtensa: xtfpga: fix hardware lockup caused by LCD driver Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 47/65] xtensa: provide __NR_sync_file_range2 instead of __NR_sync_file_range Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 48/65] gpio: mvebu: Fix mask/unmask managment per irq chip type Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 49/65] Drivers: hv: vmbus: Fix a bug in the error path in vmbus_open() Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 50/65] mvsas: fix panic on expander attached SATA devices Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 51/65] [media] stk1160: Make sure current buffer is released Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 52/65] IB/core: disallow registering 0-sized memory region Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 53/65] IB/core: dont disallow registering region starting at 0x0 Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 54/65] IB/mlx4: Fix WQE LSO segment calculation Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 55/65] tracing: Handle ftrace_dump() atomic context in graph_trace_open() Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 56/65] i2c: core: Export bus recovery functions Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 57/65] drm/radeon: fix doublescan modes (v2) Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 58/65] drm/i915: cope with large i2c transfers Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 59/65] RCU pathwalk breakage when running into a symlink overmounting something Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 60/65] ksoftirqd: Enable IRQs and call cond_resched() before poking RCU Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 61/65] e1000: add dummy allocator to fix race condition between mtu change and netpoll Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 62/65] lib: memzero_explicit: use barrier instead of OPTIMIZER_HIDE_VAR Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 63/65] wl18xx: show rx_frames_per_rates as an array as it really is Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 64/65] C6x: time: Ensure consistency in __init Greg Kroah-Hartman
2015-05-02 19:04 ` [PATCH 3.10 65/65] memstick: mspro_block: add missing curly braces Greg Kroah-Hartman
2015-05-03 19:49 ` [PATCH 3.10 00/65] 3.10.77-stable review Guenter Roeck
2015-05-04 4:40 ` Guenter Roeck
2015-05-04 8:09 ` Heiko Carstens
2015-05-04 9:54 ` Jiri Slaby
2015-05-04 10:40 ` Heiko Carstens
2015-05-04 21:38 ` Greg Kroah-Hartman
2015-05-04 18:51 ` Guenter Roeck
2015-05-05 4:42 ` Guenter Roeck
2015-05-05 21:59 ` Greg Kroah-Hartman
2015-05-04 21:40 ` Greg Kroah-Hartman
2015-05-04 16:16 ` Shuah Khan
2015-05-04 21:42 ` Greg Kroah-Hartman
2015-05-04 22:13 ` Shuah Khan
2015-05-04 22:24 ` Guenter Roeck
2015-05-05 21:58 ` Greg Kroah-Hartman
2015-05-05 22:05 ` Greg Kroah-Hartman
2015-05-06 3:31 ` Guenter Roeck
2015-05-06 16:01 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150502190114.555225285@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=shuah.kh@samsung.com \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox