Re: [PATCH 3.10 00/65] 3.10.77-stable review

Guenter Roeck
2015-05-05T04:43:11Z

[-- Attachment #1: Type: text/plain, Size: 3388 bytes --]

On 05/03/2015 09:40 PM, Guenter Roeck wrote:
> On 05/03/2015 12:49 PM, Guenter Roeck wrote:
>> On 05/02/2015 12:03 PM, Greg Kroah-Hartman wrote:
>>> This is the start of the stable review cycle for the 3.10.77 release.
>>> There are 65 patches in this series, all will be posted as a response
>>> to this one. If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Mon May 4 19:00:04 UTC 2015.
>>> Anything received after that time might be too late.
>>>
>>
>> Build results:
>> total: 127 pass: 113 fail: 14
>> Failed builds:
>> arm:allmodconfig
>> arm:multi_v7_defconfig
>> arm:bcm2835_defconfig
>> arm:orion5x_defconfig
>> arm:kirkwood_defconfig
>> arm:mvebu_defconfig
>> mips:allmodconfig
>> powerpc:allmodconfig
>> powerpc:ppc6xx_defconfig
>> s390:defconfig
>> s390:allmodconfig
>> sparc64:allmodconfig
>> x86_64:allyesconfig
>> x86_64:allmodconfig
>>
>> Qemu test results:
>> total: 27 pass: 17 fail: 10
>> Failed tests:
>> arm:arm_versatile_defconfig
>> microblaze:microblaze_defconfig
>> powerpc:ppc_book3s_defconfig
>> powerpc:ppc_book3s_smp_defconfig
>> powerpc:ppc64_book3s_defconfig
>> powerpc:ppc64_book3s_smp_defconfig
>> x86:x86_pc_defconfig
>> x86:x86_pc_nosmp_defconfig
>> x86_64:x86_64_pc_defconfig
>> x86_64:x86_64_pc_nosmp_defconfig
>>
>> Builds fail with:
>>
>> kernel/trace/trace_functions_graph.c: In function 'graph_trace_open':
>> kernel/trace/trace_functions_graph.c:1397:2: error: implicit declaration of function 'alloc_percpu_gfp' [-Werror=implicit-function-declaration]
>> kernel/trace/trace_functions_graph.c:1397:36: error: expected expression before 'struct'
>>
>> Bisect points to 'tracing: Handle ftrace_dump() atomic context in graph_trace_open()'.
>>
>
> Also, for s390, similar to the error seen in 3.14:
>
> arch/s390/kernel/suspend.c: In function 'pfn_is_nosave':
> arch/s390/kernel/suspend.c:141:30: error: '_eshared' undeclared (first use in this function)
> arch/s390/kernel/suspend.c:141:30: note: each undeclared identifier is reported only once for each function it appears in
> arch/s390/kernel/suspend.c:142:28: error: '_stext' undeclared (first use in this function)
> arch/s390/kernel/suspend.c:151:10: error: 'ipl_info' undeclared (first use in this function)
> arch/s390/kernel/suspend.c:151:27: error: 'IPL_TYPE_NSS' undeclared (first use in this function)
>
> Presumably for the same reason ('s390/hibernate: fix save and restore of kernel text section').
>
> Guenter
>
Much better, but s390 images still fail to build:

arch/s390/kernel/suspend.c: In function 'pfn_is_nosave':
arch/s390/kernel/suspend.c:147:10: error: 'ipl_info' undeclared (first use in this function)
arch/s390/kernel/suspend.c:147:10: note: each undeclared identifier is reported only once for each function it appears in
arch/s390/kernel/suspend.c:147:27: error: 'IPL_TYPE_NSS' undeclared (first use in this function)
make[2]: *** [arch/s390/kernel/suspend.o] Error 1

The problem can be fixed by adding "#include <asm/ipl.h>" to
arch/s390/kernel/suspend.c in "s390/hibernate: fix save and restore
of kernel text section" or possibly in "nosave: consolidate
__nosave_{begin,end} in <asm/sections.h>". Or, of course,
in a separate patch, such as the one attached.

Guenter

[-- Attachment #2: 0001-s390-Fix-build-error.patch --]
[-- Type: text/x-diff, Size: 955 bytes --]

>From 5eca5cfdb114a2ccff8bf25c2273104eb8946b55 Mon Sep 17 00:00:00 2001
From: Guenter Roeck <linux@roeck-us.net>
Date: Mon, 4 May 2015 21:40:06 -0700
Subject: [PATCH v3.10] s390: Fix build error

s390 images fail to build in 3.10 with

arch/s390/kernel/suspend.c: In function 'pfn_is_nosave':
arch/s390/kernel/suspend.c:147:10: error: 'ipl_info' undeclared
arch/s390/kernel/suspend.c:147:27: error: 'IPL_TYPE_NSS' undeclared

due to a missing include file.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
arch/s390/kernel/suspend.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/s390/kernel/suspend.c b/arch/s390/kernel/suspend.c
index a3ab6798ce68..58cbb75e89e9 100644
--- a/arch/s390/kernel/suspend.c
+++ b/arch/s390/kernel/suspend.c
@@ -11,6 +11,7 @@
#include <linux/mm.h>
#include <asm/sections.h>
#include <asm/ctl_reg.h>
+#include <asm/ipl.h>

/*
* The restore of the saved pages in an hibernation image will set
--
2.1.0