From: Andrew Morton <akpm@linux-foundation.org>
To: DaeSeok Youn <daeseok.youn@gmail.com>
Cc: "ocfs2-devel@oss.oracle.com" <ocfs2-devel@oss.oracle.com>,
mfasheh@suse.com, linux-kernel <linux-kernel@vger.kernel.org>,
Richard Weinberger <richard@nod.at>,
Joseph Qi <joseph.qi@huawei.com>
Subject: Re: [PATCH RESEND] ocfs2: use retval instead of status for checking error
Date: Sat, 2 May 2015 21:13:19 -0700 [thread overview]
Message-ID: <20150502211319.0d406048.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAHb8M2Ck9x25O3JMQm0nqJriWx6QMb8DyO=O7Asw3JYk8kBNuw@mail.gmail.com>
On Sun, 3 May 2015 12:02:39 +0900 DaeSeok Youn <daeseok.youn@gmail.com> wrote:
> 2015-04-24 10:45 GMT+09:00 Daeseok Youn <daeseok.youn@gmail.com>:
> > The use of 'status' in __ocfs2_add_entry() can return wrong
> > value. Some functions' return value in __ocfs2_add_entry(),
> > i.e ocfs2_journal_access_di() is saved to 'status'.
> > But 'status' is not used in 'bail' label for returning result
> > of __ocfs2_add_entry().
> >
> > So use retval instead of status.
> >
> > Reviewed-by: Joseph Qi <joseph.qi@huawei.com>
> > Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> > ---
> Andrew.
>
> How is it going this patch, please check for me.
I merged this over a week ago and it is in linux-next:
http://ozlabs.org/~akpm/mmotm/broken-out/ocfs2-use-retval-instead-of-status-for-checking-error.patch
You were sent a commit email at the time.
next prev parent reply other threads:[~2015-05-03 4:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 1:45 [PATCH RESEND] ocfs2: use retval instead of status for checking error Daeseok Youn
2015-04-29 0:06 ` DaeSeok Youn
2015-05-03 3:02 ` DaeSeok Youn
2015-05-03 4:13 ` Andrew Morton [this message]
2015-05-03 7:35 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150502211319.0d406048.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=daeseok.youn@gmail.com \
--cc=joseph.qi@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mfasheh@suse.com \
--cc=ocfs2-devel@oss.oracle.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox