From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751212AbbECEHP (ORCPT ); Sun, 3 May 2015 00:07:15 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49140 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897AbbECEHJ (ORCPT ); Sun, 3 May 2015 00:07:09 -0400 Date: Sat, 2 May 2015 21:13:19 -0700 From: Andrew Morton To: DaeSeok Youn Cc: "ocfs2-devel@oss.oracle.com" , mfasheh@suse.com, linux-kernel , Richard Weinberger , Joseph Qi Subject: Re: [PATCH RESEND] ocfs2: use retval instead of status for checking error Message-Id: <20150502211319.0d406048.akpm@linux-foundation.org> In-Reply-To: References: <20150424014545.GA9252@devel.8.8.4.4> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 3 May 2015 12:02:39 +0900 DaeSeok Youn wrote: > 2015-04-24 10:45 GMT+09:00 Daeseok Youn : > > The use of 'status' in __ocfs2_add_entry() can return wrong > > value. Some functions' return value in __ocfs2_add_entry(), > > i.e ocfs2_journal_access_di() is saved to 'status'. > > But 'status' is not used in 'bail' label for returning result > > of __ocfs2_add_entry(). > > > > So use retval instead of status. > > > > Reviewed-by: Joseph Qi > > Signed-off-by: Daeseok Youn > > --- > Andrew. > > How is it going this patch, please check for me. I merged this over a week ago and it is in linux-next: http://ozlabs.org/~akpm/mmotm/broken-out/ocfs2-use-retval-instead-of-status-for-checking-error.patch You were sent a commit email at the time.