Re: [PATCH v4 WIP 1/4] parport: add device-model to parport subsystem

[Jean Delvare <jdelvare@suse.de>]

Hi Sudip,

On Sun, 3 May 2015 12:07:33 +0530, Sudip Mukherjee wrote:
> On Sat, May 02, 2015 at 04:20:53PM +0200, Jean Delvare wrote:
> > On Tue, 28 Apr 2015 17:00:20 +0530, Sudip Mukherjee wrote:
> > > another WIP for your review. since this is not a formal patch for
> > > applying so writing the comments here.
> > 
> > You should still provide a proper description as if the patch was ready
> > to be committed. Ultimately the descriptions are going to be part of
> > the commits, so they need to be reviewed too.
> > 
> > The history is good to have too for now, but it should go after the
> > "---" separator, as it won't be part of the commit.
> should i then send a v5 of WIP with proper commit message?

Do not resend just for this. But please do it for the next iteration.

> > > (...)
> > > Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> > > ---
> > >  drivers/parport/parport_pc.c |   4 +-
> > >  drivers/parport/procfs.c     |  15 ++-
> > >  drivers/parport/share.c      | 266 ++++++++++++++++++++++++++++++++++++++++---
> > >  include/linux/parport.h      |  41 ++++++-
> > >  4 files changed, 308 insertions(+), 18 deletions(-)
> > > (...)
> > 
> > Patch tested, no functional regression found.
> > 
> > Tested-by: Jean Delvare <jdelvare@suse.de>
> Thanks Jean.
> Should i add your Tested-by: to the main patch and the patch
> concerning the changes to i2c-parport?

I have only tested the main patch at this point, I'll test the
i2c-parport changes later today and report then.

-- 
Jean Delvare
SUSE L3 Support