From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751759AbbECSs2 (ORCPT ); Sun, 3 May 2015 14:48:28 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52199 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751618AbbECSsW (ORCPT ); Sun, 3 May 2015 14:48:22 -0400 Date: Sun, 3 May 2015 20:29:33 +0200 From: Greg KH To: Kai Katsumata Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] fix code style in socklnd_proto.c Message-ID: <20150503182933.GA7356@kroah.com> References: <1428330093-81788-1-git-send-email-imperialroyalguard38@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428330093-81788-1-git-send-email-imperialroyalguard38@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 06, 2015 at 11:21:33PM +0900, Kai Katsumata wrote: > fix coding style by ./scripts/checkpatch.pl. > fix 80 charracters limit, space prohibited between function name and > open parenthesis '(' > and braces {} are not necessary for single statement blocks. That's two different things, so this should be two different patches. Each patch should only do one logical thing. > > Before patch is html format. But this is plain text format. > Before patch is From: line didn't match the Signed-off-by line. Align > the these lines. This paragraph doesn't need to be here, please put it below the --- line so it doesn't show up in the changelog. thanks, greg k-h