From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751915AbbECTEW (ORCPT ); Sun, 3 May 2015 15:04:22 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52331 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751770AbbECTDg (ORCPT ); Sun, 3 May 2015 15:03:36 -0400 Date: Sun, 3 May 2015 20:49:50 +0200 From: Greg KH To: Giedrius =?utf-8?Q?Statkevi=C4=8Dius?= Cc: lidza.louina@gmail.com, markh@compro.net, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2 RESEND] staging: dgnc: remove dead code in dgnc_tty_write() Message-ID: <20150503184950.GA1482@kroah.com> References: <1428677335-6853-1-git-send-email-giedrius.statkevicius@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1428677335-6853-1-git-send-email-giedrius.statkevicius@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 10, 2015 at 05:48:54PM +0300, Giedrius Statkevičius wrote: > Remove the dead code protected by in_user in dgnc_tty_write() because it is set > to 0 and never changed to 1 thus the code in ifs never gets executed. Please wrap your commit lines at 72 columns in the future.