From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751696AbbECT1N (ORCPT ); Sun, 3 May 2015 15:27:13 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:47302 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751361AbbECT1J (ORCPT ); Sun, 3 May 2015 15:27:09 -0400 X-Originating-IP: 50.43.43.179 Date: Sun, 3 May 2015 12:27:02 -0700 From: Josh Triplett To: Nicolas Iooss Cc: "Paul E. McKenney" , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , linux-kernel@vger.kernel.org Subject: Re: [PATCH] rcu: declare rcu_data variables in the section they are defined in Message-ID: <20150503192701.GB2206@x> References: <1430647073-19753-1-git-send-email-nicolas.iooss_linux@m4x.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430647073-19753-1-git-send-email-nicolas.iooss_linux@m4x.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 03, 2015 at 05:57:53PM +0800, Nicolas Iooss wrote: > Commit 11bbb235c26f ("rcu: Use DEFINE_PER_CPU_SHARED_ALIGNED for > rcu_data") replaced DEFINE_PER_CPU by DEFINE_PER_CPU_SHARED_ALIGNED in > the definition of rcu_sched and rcu_bh without updating > kernel/rcu/tree.h. > > This makes clang report a section mismatch (-Wsection warning) when > building LLVMLinux because the variables are declared in .data..percpu > but defined in .data..percpu..shared_aligned. > > Signed-off-by: Nicolas Iooss Good catch. Reviewed-by: Josh Triplett > --- > kernel/rcu/tree.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h > index a69d3dab2ec4..c5e85b27a79f 100644 > --- a/kernel/rcu/tree.h > +++ b/kernel/rcu/tree.h > @@ -519,10 +519,10 @@ extern struct list_head rcu_struct_flavors; > * RCU implementation internal declarations: > */ > extern struct rcu_state rcu_sched_state; > -DECLARE_PER_CPU(struct rcu_data, rcu_sched_data); > +DECLARE_PER_CPU_SHARED_ALIGNED(struct rcu_data, rcu_sched_data); > > extern struct rcu_state rcu_bh_state; > -DECLARE_PER_CPU(struct rcu_data, rcu_bh_data); > +DECLARE_PER_CPU_SHARED_ALIGNED(struct rcu_data, rcu_bh_data); > > #ifdef CONFIG_PREEMPT_RCU > extern struct rcu_state rcu_preempt_state; > -- > 2.3.6 >