From: Luis Henriques <luis.henriques@canonical.com>
To: "Du, Changbin" <changbin.du@intel.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
"balbi@ti.com" <balbi@ti.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Cohen, David A" <david.a.cohen@intel.com>,
"Wu, Hao" <hao.wu@intel.com>
Subject: Re: [PATCH] usb: gadget: composite: enable BESL support
Date: Mon, 4 May 2015 10:16:22 +0100 [thread overview]
Message-ID: <20150504091622.GC1792@ares.olymp> (raw)
In-Reply-To: <0C18FE92A7765D4EB9EE5D38D86A563A01CDD6AE@SHSMSX103.ccr.corp.intel.com>
On Tue, Apr 28, 2015 at 07:56:13AM +0000, Du, Changbin wrote:
> From a6615937bcd9234e6d6bb817c3701fce44d0a84d Mon Sep 17 00:00:00 2001
> From: Felipe Balbi <balbi@ti.com>
> Date: Tue, 30 Sep 2014 16:08:03 -0500
> Subject: [PATCH] usb: gadget: composite: enable BESL support
>
> According to USB 2.0 ECN Errata for Link Power
> Management (USB2-LPM-Errata-final.pdf), BESL
> must be enabled if LPM is enabled.
>
> This helps with USB30CV TD 9.21 LPM L1
> Suspend Resume Test.
>
> Cc: <stable@vger.kernel.org> # 3.14
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Du, Changbin <changbin.du@intel.com>
> ---
> Hi,
>
> This patch was introduced on v3.18. However the issue fixed already existed on
> v3.14 and v3.14 is a long term support version.
>
> So propose to backport it over there as well.
>
Thank you, I'm also queuing it for the 3.16 kernel.
Cheers,
--
Luís
> Du, Changbin
> ---
> drivers/usb/gadget/composite.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
> index a8c18df..f6a51fd 100644
> --- a/drivers/usb/gadget/composite.c
> +++ b/drivers/usb/gadget/composite.c
> @@ -560,7 +560,7 @@ static int bos_desc(struct usb_composite_dev *cdev)
> usb_ext->bLength = USB_DT_USB_EXT_CAP_SIZE;
> usb_ext->bDescriptorType = USB_DT_DEVICE_CAPABILITY;
> usb_ext->bDevCapabilityType = USB_CAP_TYPE_EXT;
> - usb_ext->bmAttributes = cpu_to_le32(USB_LPM_SUPPORT);
> + usb_ext->bmAttributes = cpu_to_le32(USB_LPM_SUPPORT | USB_BESL_SUPPORT);
>
> /*
> * The Superspeed USB Capability descriptor shall be implemented by all
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-05-04 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 7:56 [PATCH] usb: gadget: composite: enable BESL support Du, Changbin
2015-04-28 15:45 ` Felipe Balbi
2015-04-29 3:04 ` Du, Changbin
2015-04-29 5:53 ` Felipe Balbi
2015-05-04 9:16 ` Luis Henriques [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150504091622.GC1792@ares.olymp \
--to=luis.henriques@canonical.com \
--cc=balbi@ti.com \
--cc=changbin.du@intel.com \
--cc=david.a.cohen@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox