From: Mark Brown <broonie@kernel.org>
To: "Krzysztof Kozłowski" <k.kozlowski.k@gmail.com>
Cc: Axel Lin <axel.lin@ingics.com>,
Jaewon Kim <jaewon02.kim@samsung.com>,
Beomho Seo <beomho.seo@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RFT][PATCH 2/2] regulator: max77843: Convert to use regulator_is_enabled_regmap
Date: Mon, 4 May 2015 13:28:10 +0100 [thread overview]
Message-ID: <20150504122810.GT15510@sirena.org.uk> (raw)
In-Reply-To: <CAJKOXPckcNq-2R_jn1f=d6ph23_EjbKuJ+4MRdFYkBF0q1018g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 649 bytes --]
On Fri, May 01, 2015 at 04:54:08PM +0900, Krzysztof Kozłowski wrote:
> 2015-05-01 15:17 GMT+09:00 Axel Lin <axel.lin@ingics.com>:
> > Use regulator_is_enabled_regmap() to replace max77843_reg_is_enabled().
> I did not update the max77843 driver with such change (as did for max77693)
> because I think they should be merged:
> https://lkml.org/lkml/2015/4/29/185
> These devices are almost the same.
I can't see that link since I don't have internet access right now but
surely it's going to be clearer that the code for the devices is the
same if we make updates like this to both devices? Otherwise it's less
obvious on review.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-05-04 13:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 6:16 [RFT][PATCH 1/2] regulator: max77843: Fix enable_mask for max77843 charger Axel Lin
2015-05-01 6:17 ` [RFT][PATCH 2/2] regulator: max77843: Convert to use regulator_is_enabled_regmap Axel Lin
2015-05-01 7:56 ` Krzysztof Kozłowski
[not found] ` <CAJKOXPckcNq-2R_jn1f=d6ph23_EjbKuJ+4MRdFYkBF0q1018g@mail.gmail.com>
2015-05-04 12:28 ` Mark Brown [this message]
2015-05-04 13:56 ` Krzysztof Kozłowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150504122810.GT15510@sirena.org.uk \
--to=broonie@kernel.org \
--cc=axel.lin@ingics.com \
--cc=beomho.seo@samsung.com \
--cc=jaewon02.kim@samsung.com \
--cc=k.kozlowski.k@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox