From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753171AbbEDODS (ORCPT ); Mon, 4 May 2015 10:03:18 -0400 Received: from mail.kernel.org ([198.145.29.136]:41152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753113AbbEDODG (ORCPT ); Mon, 4 May 2015 10:03:06 -0400 Date: Mon, 4 May 2015 16:02:54 +0200 From: Sebastian Reichel To: Arnd Bergmann Cc: Pavel Machek , Aaro Koskinen , Kai Vehmanen , linux-kernel@vger.kernel.org Subject: Re: [PATCH] HSI: cmt_speech: fix timestamp interface Message-ID: <20150504140254.GB13164@earth> References: <2731231.Ic3nBHVb1n@wuerfel> <1429204430-26807-1-git-send-email-sre@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NMuMz9nt05w80d4+" Content-Disposition: inline In-Reply-To: <1429204430-26807-1-git-send-email-sre@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --NMuMz9nt05w80d4+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Arnd, On Thu, Apr 16, 2015 at 07:13:50PM +0200, Sebastian Reichel wrote: > The user interface for timestamps in the new cmt_speech > driver is broken in multiple ways: >=20 > - The layout is incompatible between 32-bit and 64-bit user > space, because of the size differences in 'struct timespec'. > This means that the driver can not work when used with 32-bit > user space on a 64-bit kernel. >=20 > - As there are plans to change 32-bit user space to use > a 64-bit time_t type in the future, it will also be > incompatible with new 32-bit user space. >=20 > To keep support for the user space tools written for this driver (which > have lived many years out-of-tree), the interface has been hardened to > unsigned 32-bit values. Are you fine with this patch? I would like to queue it for 4.1-rc. -- Sebastian --NMuMz9nt05w80d4+ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJVR3wLAAoJENju1/PIO/qa1UgP/ik0KSgvSi3qR2ugDtJu1knD lF4jvbvAWVb4kHr/xwnKjayKQcojVCdfgiwIVZMHxUAdidfT2/IcF1N5RK8ZTRm7 3JVvdDaD6HmwRj5zFB51INaaERzXxnCxSGA3BAAEjT35T1/lSYIJcIHLZ3TjHtOj rw5t9JonREkI6eWhIU/TYWFjFNMXkXlA6bIkZzyVNkZoV39HxffWJ2jlQb6Pl6YN jiptzytGolXvF2cdDOUvCXZL09KwZPyvnZkXfoIefN6bETSqc60bOhA6v3CfQ5M3 7EjBLBa7JCzAjvQx2zv9F6Sd0q2KhpbUZKzcj9mczXf5p6cbDRO+baE+4AARIlto IvvqJqL4e0s/w0hayqpFpI8htjOP3PF89PGDELRtcPgiSBlZlUb8HysREtbOs8AJ CZKy3Rtj3Lsz3mmEuHO0Sjl+MyJ7NUa9Z5XVjM/6gZrpJhBiqn7Mkp+gfROfbP/4 KtAS//5FzXRK3oZ8zFUOFBRJ90yxxhFbIyuQaCagmq8U6oZklxaeRS5KVAwrA7+H JaPB/sqHhNJ+E92IuVeo+HnhBGo1NQxVzG0NjFl9neQlL8/wXBHLas5kgKv1EGYQ GuvPTeEe6oWYq9vnSFnMMPq7mFD0FiAAPxvaguQiuZg0b/cdLlN9e1ark416LjQ1 0sLlIdriRzda4VwJVN/G =2e+K -----END PGP SIGNATURE----- --NMuMz9nt05w80d4+--