From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751564AbbEDWSJ (ORCPT ); Mon, 4 May 2015 18:18:09 -0400 Received: from skprod3.natinst.com ([130.164.80.24]:55229 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750933AbbEDWSF (ORCPT ); Mon, 4 May 2015 18:18:05 -0400 Date: Mon, 4 May 2015 17:18:04 -0500 From: Nathan Sullivan To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: macb: Do not enable RX buffer used interrupt Message-ID: <20150504221804.GA24341@nathan3500-linux-VM> References: <1430761396-4878-1-git-send-email-nathan.sullivan@ni.com> MIME-Version: 1.0 In-Reply-To: <1430761396-4878-1-git-send-email-nathan.sullivan@ni.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6|November 21, 2013) at 05/04/2015 05:18:04 PM, Serialize by Router on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6|November 21, 2013) at 05/04/2015 05:18:04 PM, Serialize complete at 05/04/2015 05:18:04 PM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-05-04_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 04, 2015 at 12:43:15PM -0500, Nathan Sullivan wrote: > This driver does not handle the RX buffer used interrupt, nor does > it need to due to handling the RX overflow interrupt already. Enabling > the interrupt would lead to an infinite loop in the ISR. > Well, that may have been premature. We are seeing the RXUBR interrupt get stuck asserted on Zynq hardware, and I failed to realize the driver clears RXUBR already in macb_interrupt... Not enabling that interrupt keeps my system responsive, but it's not the correct solution to this issue.