From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030645AbbEEHfZ (ORCPT ); Tue, 5 May 2015 03:35:25 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:33667 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752667AbbEEHfS (ORCPT ); Tue, 5 May 2015 03:35:18 -0400 Date: Tue, 5 May 2015 09:35:17 +0200 From: Johan Hovold To: Ian Stakenvicius Cc: johan@kernel.org, linux-usb@vger.kernel.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cypress_m8: please add vendor/product id to support Prior Scientific OptiScan2 Message-ID: <20150505073517.GA23199@localhost> References: <55479407.4050909@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55479407.4050909@gentoo.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 04, 2015 at 11:45:11AM -0400, Ian Stakenvicius wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > The microscope automation controllers from Prior Scientific, > specifically the OptiScan2 controller (the only one I have access to at > present) use a Cypress CY7C64013-SXC for USB->serial conversion. I've > tested the following patch against drivers/usb/serial/cypress_m8.{c,h} > with success (it just adds the vendor-id and product-id), and I was > wondering if it could be added to the kernel? Thanks for the patch. Please always run your patches through scripts/checkpatch.pl before submitting, it would have told you that you forgot to sign-off. You should include the patch inline in your mail rather than as an attachment (also read Documentation/SubmittingPatches). git format-patch and send-mail can be quite useful. An example of what such a patch could look like can be found here: http://www.spinics.net/lists/linux-usb/msg123868.html Care to fix that up and resend? Thanks, Johan