From: Dan Carpenter <dan.carpenter@oracle.com>
To: Leonardo Carreras <leocarreras89@gmail.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] drivers: dma: amba-pl08x: Supress spaces in indentation
Date: Tue, 5 May 2015 11:58:23 +0300 [thread overview]
Message-ID: <20150505085823.GR14154@mwanda> (raw)
In-Reply-To: <20150505013227.GA11053@leo-Inspiron-N5110>
On Mon, May 04, 2015 at 09:32:27PM -0400, Leonardo Carreras wrote:
> Removed checkpatch reported spaces in indentation.
>
> Signed-off-by: Leonardo Carreras <leocarreras89@gmail.com>
> ---
> drivers/dma/amba-pl08x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index 49d396e..a76df61 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -474,7 +474,7 @@ static void pl08x_terminate_phy_chan(struct pl08x_driver_data *pl08x,
> u32 val = readl(ch->reg_config);
>
> val &= ~(PL080_CONFIG_ENABLE | PL080_CONFIG_ERR_IRQ_MASK |
> - PL080_CONFIG_TC_IRQ_MASK);
> + PL080_CONFIG_TC_IRQ_MASK);
Yeah, but now it doesn't line up correctly.
Do it like this:
val &= ~(PL080_CONFIG_ENABLE | PL080_CONFIG_ERR_IRQ_MASK |
PL080_CONFIG_TC_IRQ_MASK);
In other words:
[tab][space]PL080_CONFIG_TC_IRQ_MASK);
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-05 8:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 1:32 [PATCH] drivers: dma: amba-pl08x: Supress spaces in indentation Leonardo Carreras
2015-05-05 3:32 ` Vinod Koul
2015-05-05 11:18 ` Leonardo Carreras
2015-05-05 8:58 ` Dan Carpenter [this message]
2015-05-05 11:31 ` Leonardo Carreras
2015-05-05 11:35 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150505085823.GR14154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=leocarreras89@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox