* [PATCH] drivers: dma: amba-pl08x: Supress spaces in indentation
@ 2015-05-05 1:32 Leonardo Carreras
2015-05-05 3:32 ` Vinod Koul
2015-05-05 8:58 ` Dan Carpenter
0 siblings, 2 replies; 6+ messages in thread
From: Leonardo Carreras @ 2015-05-05 1:32 UTC (permalink / raw)
To: Dan Williams, Vinod Koul; +Cc: dmaengine, linux-kernel, kernel-janitors
Removed checkpatch reported spaces in indentation.
Signed-off-by: Leonardo Carreras <leocarreras89@gmail.com>
---
drivers/dma/amba-pl08x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
index 49d396e..a76df61 100644
--- a/drivers/dma/amba-pl08x.c
+++ b/drivers/dma/amba-pl08x.c
@@ -474,7 +474,7 @@ static void pl08x_terminate_phy_chan(struct pl08x_driver_data *pl08x,
u32 val = readl(ch->reg_config);
val &= ~(PL080_CONFIG_ENABLE | PL080_CONFIG_ERR_IRQ_MASK |
- PL080_CONFIG_TC_IRQ_MASK);
+ PL080_CONFIG_TC_IRQ_MASK);
writel(val, ch->reg_config);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers: dma: amba-pl08x: Supress spaces in indentation
2015-05-05 1:32 [PATCH] drivers: dma: amba-pl08x: Supress spaces in indentation Leonardo Carreras
@ 2015-05-05 3:32 ` Vinod Koul
2015-05-05 11:18 ` Leonardo Carreras
2015-05-05 8:58 ` Dan Carpenter
1 sibling, 1 reply; 6+ messages in thread
From: Vinod Koul @ 2015-05-05 3:32 UTC (permalink / raw)
To: Leonardo Carreras; +Cc: Dan Williams, dmaengine, linux-kernel, kernel-janitors
On Mon, May 04, 2015 at 09:32:27PM -0400, Leonardo Carreras wrote:
> Removed checkpatch reported spaces in indentation.
>
You should look at git log to come up with patch tags for a subsystem, if
you had done that you would have noticed that we use dmaengine:....
Also you should have run checkpatch and that would have told you a typo in
changelog
Lastly, you should mention which error/warn your are fixing in log.
I have fixed first two and applied this
--
~Vinod
> Signed-off-by: Leonardo Carreras <leocarreras89@gmail.com>
> ---
> drivers/dma/amba-pl08x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index 49d396e..a76df61 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -474,7 +474,7 @@ static void pl08x_terminate_phy_chan(struct pl08x_driver_data *pl08x,
> u32 val = readl(ch->reg_config);
>
> val &= ~(PL080_CONFIG_ENABLE | PL080_CONFIG_ERR_IRQ_MASK |
> - PL080_CONFIG_TC_IRQ_MASK);
> + PL080_CONFIG_TC_IRQ_MASK);
>
> writel(val, ch->reg_config);
>
> --
> 1.7.9.5
>
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers: dma: amba-pl08x: Supress spaces in indentation
2015-05-05 3:32 ` Vinod Koul
@ 2015-05-05 11:18 ` Leonardo Carreras
0 siblings, 0 replies; 6+ messages in thread
From: Leonardo Carreras @ 2015-05-05 11:18 UTC (permalink / raw)
To: Vinod Koul; +Cc: Dan Williams, dmaengine, linux-kernel, kernel-janitors
Dear Vinod,
On Mon, May 4, 2015 at 11:32 PM, Vinod Koul <vinod.koul@intel.com> wrote:
> On Mon, May 04, 2015 at 09:32:27PM -0400, Leonardo Carreras wrote:
>> Removed checkpatch reported spaces in indentation.
>>
> You should look at git log to come up with patch tags for a subsystem, if
> you had done that you would have noticed that we use dmaengine:....
>
> Also you should have run checkpatch and that would have told you a typo in
> changelog
>
As this was my first attempt, I have to say sorry for the inconveniences. I will
definitely take this in account.
> Lastly, you should mention which error/warn your are fixing in log.
>
It was an error in line 477, sorry for that too.
> I have fixed first two and applied this
>
> --
> ~Vinod
>
>> Signed-off-by: Leonardo Carreras <leocarreras89@gmail.com>
>> ---
>> drivers/dma/amba-pl08x.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
>> index 49d396e..a76df61 100644
>> --- a/drivers/dma/amba-pl08x.c
>> +++ b/drivers/dma/amba-pl08x.c
>> @@ -474,7 +474,7 @@ static void pl08x_terminate_phy_chan(struct pl08x_driver_data *pl08x,
>> u32 val = readl(ch->reg_config);
>>
>> val &= ~(PL080_CONFIG_ENABLE | PL080_CONFIG_ERR_IRQ_MASK |
>> - PL080_CONFIG_TC_IRQ_MASK);
>> + PL080_CONFIG_TC_IRQ_MASK);
>>
>> writel(val, ch->reg_config);
>>
>> --
>> 1.7.9.5
>>
>
> --
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers: dma: amba-pl08x: Supress spaces in indentation
2015-05-05 1:32 [PATCH] drivers: dma: amba-pl08x: Supress spaces in indentation Leonardo Carreras
2015-05-05 3:32 ` Vinod Koul
@ 2015-05-05 8:58 ` Dan Carpenter
2015-05-05 11:31 ` Leonardo Carreras
1 sibling, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2015-05-05 8:58 UTC (permalink / raw)
To: Leonardo Carreras
Cc: Dan Williams, Vinod Koul, dmaengine, linux-kernel,
kernel-janitors
On Mon, May 04, 2015 at 09:32:27PM -0400, Leonardo Carreras wrote:
> Removed checkpatch reported spaces in indentation.
>
> Signed-off-by: Leonardo Carreras <leocarreras89@gmail.com>
> ---
> drivers/dma/amba-pl08x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index 49d396e..a76df61 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -474,7 +474,7 @@ static void pl08x_terminate_phy_chan(struct pl08x_driver_data *pl08x,
> u32 val = readl(ch->reg_config);
>
> val &= ~(PL080_CONFIG_ENABLE | PL080_CONFIG_ERR_IRQ_MASK |
> - PL080_CONFIG_TC_IRQ_MASK);
> + PL080_CONFIG_TC_IRQ_MASK);
Yeah, but now it doesn't line up correctly.
Do it like this:
val &= ~(PL080_CONFIG_ENABLE | PL080_CONFIG_ERR_IRQ_MASK |
PL080_CONFIG_TC_IRQ_MASK);
In other words:
[tab][space]PL080_CONFIG_TC_IRQ_MASK);
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers: dma: amba-pl08x: Supress spaces in indentation
2015-05-05 8:58 ` Dan Carpenter
@ 2015-05-05 11:31 ` Leonardo Carreras
2015-05-05 11:35 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: Leonardo Carreras @ 2015-05-05 11:31 UTC (permalink / raw)
To: Dan Carpenter
Cc: Dan Williams, Vinod Koul, dmaengine, linux-kernel,
kernel-janitors
Dear Dan,
On Tue, May 5, 2015 at 4:58 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Mon, May 04, 2015 at 09:32:27PM -0400, Leonardo Carreras wrote:
>> Removed checkpatch reported spaces in indentation.
>>
>> Signed-off-by: Leonardo Carreras <leocarreras89@gmail.com>
>> ---
>> drivers/dma/amba-pl08x.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
>> index 49d396e..a76df61 100644
>> --- a/drivers/dma/amba-pl08x.c
>> +++ b/drivers/dma/amba-pl08x.c
>> @@ -474,7 +474,7 @@ static void pl08x_terminate_phy_chan(struct pl08x_driver_data *pl08x,
>> u32 val = readl(ch->reg_config);
>>
>> val &= ~(PL080_CONFIG_ENABLE | PL080_CONFIG_ERR_IRQ_MASK |
>> - PL080_CONFIG_TC_IRQ_MASK);
>> + PL080_CONFIG_TC_IRQ_MASK);
>
> Yeah, but now it doesn't line up correctly.
>
> Do it like this:
>
> val &= ~(PL080_CONFIG_ENABLE | PL080_CONFIG_ERR_IRQ_MASK |
> PL080_CONFIG_TC_IRQ_MASK);
>
> In other words:
>
> [tab][space]PL080_CONFIG_TC_IRQ_MASK);
>
I will check this, but may I ask if that would be marked as an error
by checkpatch.
Regards,
Leo
> regards,
> dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drivers: dma: amba-pl08x: Supress spaces in indentation
2015-05-05 11:31 ` Leonardo Carreras
@ 2015-05-05 11:35 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2015-05-05 11:35 UTC (permalink / raw)
To: Leonardo Carreras
Cc: Dan Williams, Vinod Koul, dmaengine, linux-kernel,
kernel-janitors
On Tue, May 05, 2015 at 07:31:40AM -0400, Leonardo Carreras wrote:
> I will check this, but may I ask if that would be marked as an error
> by checkpatch.
No, it won't. It is the correct way.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-05 11:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-05 1:32 [PATCH] drivers: dma: amba-pl08x: Supress spaces in indentation Leonardo Carreras
2015-05-05 3:32 ` Vinod Koul
2015-05-05 11:18 ` Leonardo Carreras
2015-05-05 8:58 ` Dan Carpenter
2015-05-05 11:31 ` Leonardo Carreras
2015-05-05 11:35 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox