From: Nicholas Mc Guire <der.herr@hofr.at>
To: Gleb Natapov <gleb@kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Ralf Baechle <ralf@linux-mips.org>,
kvm@vger.kernel.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org
Subject: [BUG ?] MIPS: KVM: condition with no effect
Date: Tue, 5 May 2015 14:34:38 +0200 [thread overview]
Message-ID: <20150505123438.GA21514@opentech.at> (raw)
Hi !
Not sure if this is a bug or maybe a placeholder for
something... so patch - but maybe someone that knows this code can
give it a look.
arch/mips/kvm/emulate.c:emulation_result kvm_mips_complete_mmio_load()
<snip>
2414 case 2:
2415 if (vcpu->mmio_needed == 2)
2416 *gpr = *(int16_t *) run->mmio.data;
2417 else
2418 *gpr = *(int16_t *) run->mmio.data;
2419
2420 break;
<snip>
either the if/else is not needed or one of the branches is wrong
or it is a place-holder for somethign that did not get
done - in which case a few lines explaining this would be
nice (e.g. like in arch/sh/kernel/traps_64.c line 59)
line numbers refer to 4.1-rc2
thx!
hofrat
next reply other threads:[~2015-05-05 12:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 12:34 Nicholas Mc Guire [this message]
2015-05-05 21:42 ` [BUG ?] MIPS: KVM: condition with no effect James Hogan
2015-05-07 12:18 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150505123438.GA21514@opentech.at \
--to=der.herr@hofr.at \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=pbonzini@redhat.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox