From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759062AbbEEQGp (ORCPT ); Tue, 5 May 2015 12:06:45 -0400 Received: from mail.kernel.org ([198.145.29.136]:32996 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2993165AbbEEOWh (ORCPT ); Tue, 5 May 2015 10:22:37 -0400 Date: Tue, 5 May 2015 11:22:31 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH v2 10/10] perf tools: Move TUI-specific fields out of map_symbol Message-ID: <20150505142231.GL10475@kernel.org> References: <20150504155116.GE10475@kernel.org> <1430788690-13772-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430788690-13772-1-git-send-email-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, May 05, 2015 at 10:18:10AM +0900, Namhyung Kim escreveu: > The has_children and unfolded fields don't belong to struct map_symbol > since they're used by TUI only. Move those fields out of map_symbol > since the struct is also used by other places. > This will also help to compact the sizeof struct hist_entry. > Signed-off-by: Namhyung Kim > Acked-by: Jiri Olsa In a case like this, with changes, should we keep the Ack? I guess not, the fix may introduce another problem, etc. > fix segfault due to recursion in hist_entry__set_folding(). We will need a v3, this fixes the 'E'xpand segfault, but not the first problem reported, again, this time step by step: Samples: 1K of event 'cycles', Event count (approx.): 1597853394 Children Self Command Shared Object Symbol - 99.86% 99.86% swapper [kernel.vmlinux] [k] cpu_startup_entry + cpu_startup_entry + 90.17% 0.00% swapper [kernel.vmlinux] [k] start_secondary + 9.79% 0.00% swapper [kernel.vmlinux].init.text [k] x86_64_start_kernel + 9.79% 0.00% swapper [kernel.vmlinux].init.text [k] x86_64_start_reservations + 9.79% 0.00% swapper [kernel.vmlinux].init.text [k] start_kernel + 9.79% 0.00% swapper [kernel.vmlinux] [k] rest_init + 0.08% 0.00% swapper [kernel.vmlinux] [k] thermal_interrupt --------------------------------------- See the "+ cpu_startup_entry"? If I go there and press enter, I would expect to see its callers, but what happens is: Samples: 1K of event 'cycles', Event count (approx.): 1597853394 Children Self Command Shared Object Symbol + 99.86% 99.86% swapper [kernel.vmlinux] [k] cpu_startup_entry + 90.17% 0.00% swapper [kernel.vmlinux] [k] start_secondary + 9.79% 0.00% swapper [kernel.vmlinux].init.text [k] x86_64_start_kernel + 9.79% 0.00% swapper [kernel.vmlinux].init.text [k] x86_64_start_reservations + 9.79% 0.00% swapper [kernel.vmlinux].init.text [k] start_kernel + 9.79% 0.00% swapper [kernel.vmlinux] [k] rest_init + 0.08% 0.00% swapper [kernel.vmlinux] [k] thermal_interrupt --------------------------------------- It collapses the hist_entry instead of expanding it further. I'm updating that branch, that now sits on top of what is in acme/perf/core. - Arnaldo