Re: [PATCH v2 10/10] perf tools: Move TUI-specific fields out of map_symbol

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Tue, May 05, 2015 at 11:22:31AM -0300, Arnaldo Carvalho de Melo escreveu:
> We will need a v3, this fixes the 'E'xpand segfault, but not the first
> problem reported, again, this time step by step:
 
> Samples: 1K of event 'cycles', Event count (approx.): 1597853394
>   Children      Self  Command  Shared Object               Symbol
> -   99.86%    99.86%  swapper  [kernel.vmlinux]            [k] cpu_startup_entry
>    + cpu_startup_entry
> +   90.17%     0.00%  swapper  [kernel.vmlinux]            [k] start_secondary
> ---------------------------------------
> See the "+ cpu_startup_entry"? If I go there and press enter, I would expect to
> see its callers, but what happens is:
 
> Samples: 1K of event 'cycles', Event count (approx.): 1597853394
>   Children      Self  Command  Shared Object               Symbol
> +   99.86%    99.86%  swapper  [kernel.vmlinux]            [k] cpu_startup_entry
> +   90.17%     0.00%  swapper  [kernel.vmlinux]            [k] start_secondary
> ---------------------------------------
 
> It collapses the hist_entry instead of expanding it further.

I just repeated the bisect, because I was unsure if last time I did it
using the 'E' as the good/bad determiner, the
collapse-when-it-should-expand bug described above is indeed also
introduced by this changeset.

- Arnaldo