From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759083AbbEEQGx (ORCPT ); Tue, 5 May 2015 12:06:53 -0400 Received: from mail.kernel.org ([198.145.29.136]:33182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2993175AbbEEO0a (ORCPT ); Tue, 5 May 2015 10:26:30 -0400 Date: Tue, 5 May 2015 11:26:26 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH v2 10/10] perf tools: Move TUI-specific fields out of map_symbol Message-ID: <20150505142626.GN10475@kernel.org> References: <20150504155116.GE10475@kernel.org> <1430788690-13772-1-git-send-email-namhyung@kernel.org> <20150505142231.GL10475@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150505142231.GL10475@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, May 05, 2015 at 11:22:31AM -0300, Arnaldo Carvalho de Melo escreveu: > We will need a v3, this fixes the 'E'xpand segfault, but not the first > problem reported, again, this time step by step: > Samples: 1K of event 'cycles', Event count (approx.): 1597853394 > Children Self Command Shared Object Symbol > - 99.86% 99.86% swapper [kernel.vmlinux] [k] cpu_startup_entry > + cpu_startup_entry > + 90.17% 0.00% swapper [kernel.vmlinux] [k] start_secondary > --------------------------------------- > See the "+ cpu_startup_entry"? If I go there and press enter, I would expect to > see its callers, but what happens is: > Samples: 1K of event 'cycles', Event count (approx.): 1597853394 > Children Self Command Shared Object Symbol > + 99.86% 99.86% swapper [kernel.vmlinux] [k] cpu_startup_entry > + 90.17% 0.00% swapper [kernel.vmlinux] [k] start_secondary > --------------------------------------- > It collapses the hist_entry instead of expanding it further. I just repeated the bisect, because I was unsure if last time I did it using the 'E' as the good/bad determiner, the collapse-when-it-should-expand bug described above is indeed also introduced by this changeset. - Arnaldo