* [PATCH 1/1 linux-next] iommu/msm: make msm_iommu_lock static
@ 2015-04-29 19:05 Fabian Frederick
2015-05-05 16:03 ` Joerg Roedel
0 siblings, 1 reply; 3+ messages in thread
From: Fabian Frederick @ 2015-04-29 19:05 UTC (permalink / raw)
To: linux-kernel; +Cc: Fabian Frederick, Joerg Roedel, iommu
msm_iommu_lock is only used in msm_iommu.c
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/iommu/msm_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/msm_iommu.c b/drivers/iommu/msm_iommu.c
index 15a2063..f2a6321 100644
--- a/drivers/iommu/msm_iommu.c
+++ b/drivers/iommu/msm_iommu.c
@@ -47,7 +47,7 @@ __asm__ __volatile__ ( \
static int msm_iommu_tex_class[4];
-DEFINE_SPINLOCK(msm_iommu_lock);
+static DEFINE_SPINLOCK(msm_iommu_lock);
struct msm_priv {
unsigned long *pgtable;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1 linux-next] iommu/msm: make msm_iommu_lock static
2015-04-29 19:05 [PATCH 1/1 linux-next] iommu/msm: make msm_iommu_lock static Fabian Frederick
@ 2015-05-05 16:03 ` Joerg Roedel
2015-05-05 17:19 ` Fabian Frederick
0 siblings, 1 reply; 3+ messages in thread
From: Joerg Roedel @ 2015-05-05 16:03 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, iommu
On Wed, Apr 29, 2015 at 09:05:17PM +0200, Fabian Frederick wrote:
> msm_iommu_lock is only used in msm_iommu.c
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/iommu/msm_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This driver is marked BROKEN, I think its more important to get it out
of this stage instead of those random useless cleanups.
Joerg
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1 linux-next] iommu/msm: make msm_iommu_lock static
2015-05-05 16:03 ` Joerg Roedel
@ 2015-05-05 17:19 ` Fabian Frederick
0 siblings, 0 replies; 3+ messages in thread
From: Fabian Frederick @ 2015-05-05 17:19 UTC (permalink / raw)
To: Joerg Roedel; +Cc: linux-kernel, iommu
> On 05 May 2015 at 18:03 Joerg Roedel <joro@8bytes.org> wrote:
>
>
> On Wed, Apr 29, 2015 at 09:05:17PM +0200, Fabian Frederick wrote:
> > msm_iommu_lock is only used in msm_iommu.c
> >
> > Signed-off-by: Fabian Frederick <fabf@skynet.be>
> > ---
> > drivers/iommu/msm_iommu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> This driver is marked BROKEN, I think its more important to get it out
> of this stage instead of those random useless cleanups.
Hi Joerg,
Didn't notice it was broken. Really sorry for the noise.
Regards,
Fabian
>
>
> Joerg
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-05 17:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-29 19:05 [PATCH 1/1 linux-next] iommu/msm: make msm_iommu_lock static Fabian Frederick
2015-05-05 16:03 ` Joerg Roedel
2015-05-05 17:19 ` Fabian Frederick
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox