From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] percpu_counter: batch size aware __percpu_counter_compare()
Date: Wed, 6 May 2015 15:43:10 +1000 [thread overview]
Message-ID: <20150506054310.GA4327@dastard> (raw)
In-Reply-To: <20150506043636.GA10940@infradead.org>
On Tue, May 05, 2015 at 09:36:36PM -0700, Christoph Hellwig wrote:
> This looks reasonable, but I miss Ccs to the authors of the
> percpu_counter code and linux-kernel.
linux-kernel was cc'd.
> On Wed, May 06, 2015 at 08:01:38AM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > From: Dave Chinner <dchinner@redhat.com>
>
> And this looks wrong, too :)
That looks like a change of tool behaviour. I just upgraded guilt;
the old version stripped "from" lines in patch descriptions from the
git commit log as goes into the author field of the commit. The new
version does not appear to strip the from lines, and so when
git-send-email formats it, it puts a from line in the message, and
then the commit message has one too.
Thanks for pointing it out.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2015-05-06 5:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 22:01 [PATCH 0/2] xfs: fix inode count underrun Dave Chinner
2015-05-05 22:01 ` [PATCH 1/2] percpu_counter: batch size aware __percpu_counter_compare() Dave Chinner
2015-05-06 4:36 ` Christoph Hellwig
2015-05-06 4:46 ` Christoph Hellwig
2015-05-06 5:43 ` Dave Chinner [this message]
2015-05-06 5:53 ` Dave Chinner
2015-05-06 6:11 ` Dave Chinner
2015-05-05 22:01 ` [PATCH 2/2] xfs: inode counter needs to use __percpu_counter_compare Dave Chinner
2015-05-06 4:38 ` Christoph Hellwig
2015-05-06 5:45 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2015-05-12 23:52 [PATCH 0/2 v2] percpu_counter: xfs requires custom compare batch size Dave Chinner
2015-05-12 23:52 ` [PATCH 1/2] percpu_counter: batch size aware __percpu_counter_compare() Dave Chinner
2015-05-13 13:59 ` Tejun Heo
2015-05-14 0:55 ` Dave Chinner
2015-05-14 15:02 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506054310.GA4327@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox