From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753736AbbEFFnQ (ORCPT ); Wed, 6 May 2015 01:43:16 -0400 Received: from ipmail06.adl6.internode.on.net ([150.101.137.145]:7804 "EHLO ipmail06.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbbEFFnO (ORCPT ); Wed, 6 May 2015 01:43:14 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BRCAC5qElVPH8+LHlcgwyBL4ZLrVABAQaZRQICAQECgTZNAQEBAQEBBwEBAQFBP4QgAQEBAwE6HCMFCwgDDgcDCSUPBSUDBxoTiCQHxBkBAQgCAR8YhX+FIoQiEQEPQgeDF4EWAQSPbo0EjFKJXoEDgyYsMYEEBxeBIwEBAQ Date: Wed, 6 May 2015 15:43:10 +1000 From: Dave Chinner To: Christoph Hellwig Cc: xfs@oss.sgi.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] percpu_counter: batch size aware __percpu_counter_compare() Message-ID: <20150506054310.GA4327@dastard> References: <1430863299-9341-1-git-send-email-david@fromorbit.com> <1430863299-9341-2-git-send-email-david@fromorbit.com> <20150506043636.GA10940@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150506043636.GA10940@infradead.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 05, 2015 at 09:36:36PM -0700, Christoph Hellwig wrote: > This looks reasonable, but I miss Ccs to the authors of the > percpu_counter code and linux-kernel. linux-kernel was cc'd. > On Wed, May 06, 2015 at 08:01:38AM +1000, Dave Chinner wrote: > > From: Dave Chinner > > > > From: Dave Chinner > > And this looks wrong, too :) That looks like a change of tool behaviour. I just upgraded guilt; the old version stripped "from" lines in patch descriptions from the git commit log as goes into the author field of the commit. The new version does not appear to strip the from lines, and so when git-send-email formats it, it puts a from line in the message, and then the commit message has one too. Thanks for pointing it out. Cheers, Dave. -- Dave Chinner david@fromorbit.com