From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932558AbbEFHXG (ORCPT ); Wed, 6 May 2015 03:23:06 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:56054 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932460AbbEFHXE (ORCPT ); Wed, 6 May 2015 03:23:04 -0400 Date: Wed, 6 May 2015 00:23:02 -0700 From: Stephen Boyd To: Rob Herring Cc: Mike Turquette , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] clk: mmp: add PXA1928 clock support Message-ID: <20150506072302.GE27050@codeaurora.org> References: <1430455271-20195-1-git-send-email-robh@kernel.org> <1430455271-20195-2-git-send-email-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430455271-20195-2-git-send-email-robh@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/30, Rob Herring wrote: > diff --git a/drivers/clk/mmp/clk-of-pxa1928.c b/drivers/clk/mmp/clk-of-pxa1928.c > new file mode 100644 > index 0000000..b7cb540b > --- /dev/null > +++ b/drivers/clk/mmp/clk-of-pxa1928.c > @@ -0,0 +1,265 @@ > +/* > + * pxa1928 clock framework source file > + * > + * Copyright (C) 2015 Linaro, Ltd. > + * Rob Herring > + * > + * Based on drivers/clk/mmp/clk-of-mmp2.c: > + * Copyright (C) 2012 Marvell > + * Chao Xie > + * Any reason to leave Chao off Cc? > + * This file is licensed under the terms of the GNU General Public > + * License version 2. This program is licensed "as is" without any > + * warranty of any kind, whether express or implied. > + */ > +#include This include is unused? > +#include > +#include > +#include > +#include #include ? > + > +#include > + Otherwise looks ok to me. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project