From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Jens Kuske <jenskuske@gmail.com>
Cc: "Emilio López" <emilio@elopez.com.ar>,
"Mike Turquette" <mturquette@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Vinod Koul" <vinod.koul@intel.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [PATCH 3/6] pinctrl: sunxi: Add H3 PIO controller support
Date: Wed, 6 May 2015 14:23:02 +0200 [thread overview]
Message-ID: <20150506122302.GF11057@lukather> (raw)
In-Reply-To: <5549EE36.4060603@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 853 bytes --]
On Wed, May 06, 2015 at 12:34:30PM +0200, Jens Kuske wrote:
> >> + SUNXI_PIN(SUNXI_PINCTRL_PIN(A, 6),
> >> + SUNXI_FUNCTION(0x0, "gpio_in"),
> >> + SUNXI_FUNCTION(0x1, "gpio_out"),
> >> + SUNXI_FUNCTION(0x2, "scr"), /* PWREN */
> >
> > The datasheet uses "SIM" for this, why have you changed the name here?
>
> Thought I had changed that back. I first used scr because the
> responsible module is called scr everywhere else (clocks, memory map).
> Looks like I messed it up now and called the clocks "sim" instead...
>
> I think I should also redo the dtsi and use scr for the clock again, to
> stay compatible with how it was called in Manual and earlier sunxi SoCs.
It seems reasonable :)
Thanks,
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-05-06 12:25 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 9:31 [PATCH 0/6] ARM: sunxi: Introduce Allwinner H3 support Jens Kuske
2015-05-06 9:31 ` [PATCH 1/6] " Jens Kuske
2015-05-06 10:04 ` Maxime Ripard
2015-05-06 10:23 ` Jens Kuske
2015-05-06 12:22 ` Maxime Ripard
2015-05-06 9:31 ` [PATCH 2/6] clk: sunxi: Add H3 clocks support Jens Kuske
2015-05-06 9:47 ` Chen-Yu Tsai
2015-05-06 10:18 ` Jens Kuske
2015-05-09 11:29 ` Maxime Ripard
2015-05-09 11:27 ` Maxime Ripard
2015-05-10 10:54 ` Jens Kuske
2015-05-12 14:44 ` Maxime Ripard
2015-05-14 5:14 ` Chen-Yu Tsai
2015-05-15 12:49 ` Maxime Ripard
2015-05-06 9:31 ` [PATCH 3/6] pinctrl: sunxi: Add H3 PIO controller support Jens Kuske
2015-05-06 10:11 ` Maxime Ripard
2015-05-06 10:34 ` Jens Kuske
2015-05-06 12:23 ` Maxime Ripard [this message]
2015-05-07 8:10 ` Paul Bolle
2015-05-09 9:17 ` Jens Kuske
2015-05-09 12:19 ` Maxime Ripard
2015-05-06 9:31 ` [PATCH 4/6] dmaengine: sun6i: Add support for Allwinner H3 (sun8i) variant Jens Kuske
2015-05-06 10:13 ` Maxime Ripard
2015-05-08 3:44 ` Vinod Koul
2015-05-08 7:19 ` Maxime Ripard
2015-05-08 9:26 ` Vinod Koul
2015-05-06 9:31 ` [PATCH 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jens Kuske
2015-05-06 12:19 ` Maxime Ripard
2015-05-06 20:47 ` Jens Kuske
2015-05-09 11:44 ` Maxime Ripard
2015-05-11 8:11 ` Chen-Yu Tsai
2015-05-06 9:31 ` [PATCH 6/6] ARM: dts: sun8i: Add Orange Pi Plus support Jens Kuske
2015-05-09 15:58 ` [linux-sunxi] [PATCH 0/6] ARM: sunxi: Introduce Allwinner H3 support Hans de Goede
-- strict thread matches above, loose matches on Subject: below --
2015-10-21 16:30 [PATCH 3/6] pinctrl: sunxi: Add H3 PIO controller support Jens Kuske
2015-10-22 8:16 ` Maxime Ripard
2015-10-22 8:21 ` josef.gajdusek
2015-10-22 8:30 ` Maxime Ripard
2015-10-23 8:21 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506122302.GF11057@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=emilio@elopez.com.ar \
--cc=jenskuske@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mturquette@linaro.org \
--cc=robh+dt@kernel.org \
--cc=vinod.koul@intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).