Re: [PATCH v5 1/6] x86/mm/pat: use pr_info() and friends

Luis R. Rodriguez
2015-05-14T15:55:57Z

On Thu, May 07, 2015 at 03:36:15AM +0000, Elliott, Robert (Server Storage) wrote:
> > From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-
> > owner@vger.kernel.org] On Behalf Of Luis R. Rodriguez
> > Sent: Thursday, April 30, 2015 3:25 PM
> > Subject: [PATCH v5 1/6] x86/mm/pat: use pr_info() and friends
> >
> ...
> > - printk(KERN_ERR "%s:%d map pfn expected mapping
> > type %s"
> > - " for [mem %#010Lx-%#010Lx], got %s\n",
> > - current->comm, current->pid,
> > - cattr_name(want_pcm),
> > - (unsigned long long)paddr,
> > - (unsigned long long)(paddr + size - 1),
> > - cattr_name(pcm));
> > + pr_err("%s:%d map pfn expected mapping type %s"
> > + " for [mem %#010Lx-%#010Lx], got %s\n",
>
> Since the patch joins some other print format strings split across
> lines (which checkpatch allows), you might want to join this one too.
>
> ...
> > diff --git a/arch/x86/mm/pat_rbtree.c b/arch/x86/mm/pat_rbtree.c
> ...
> > failure:
> > - printk(KERN_INFO "%s:%d conflicting memory types "
> > + pr_info("%s:%d conflicting memory types "
> > "%Lx-%Lx %s<->%s\n", current->comm, current->pid, start,
> > end, cattr_name(found_type), cattr_name(match->type));
>
> and that one.

I have adjusted this.

Boris, would you like a v6 re-spin on this series? Or just this patch, or
anthing else? FWIW since I keep having to re-do patches / rebase after a while
and the entire kill-mtrr series is large with tons of parts I've set out a tree
with all pending mtrr changes. The kill-mtrr-v5-20150514 can be used:

https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git

When needed I'll just fetch linux-next and rebase --onto that day's
origin/master.

Luis