Re: [PATCH v4 2/7] mtrr, x86: Fix MTRR lookup to handle inclusive entry

Borislav Petkov
2015-05-05T18:41:37Z

On Tue, May 05, 2015 at 11:32:08AM -0600, Toshi Kani wrote:
> > Ok, I'm confused. Shouldn't the inclusive:1 case be
> >
> > (start:mtrr_start) (mtrr_start:mtrr_end) (mtrr_end:end)
> >
> > ?
> >
> > If so, this function would need more changes...
>
> Yes, that's how it gets separated eventually. Since *repeat is set in
> this case, the code only needs to separate the first part at a time.
> The 2nd part gets separated in the next call with the *repeat.

Aah, right, the caller is supposed to adjust the interval limits on
subsequent calls. Please reflect this in the comment because:

* (start:mtrr_start) (mtrr_start:end)

is misleading for inclusive:1.

--
Regards/Gruss,
Boris.

ECO tip #101: Trim your mails when you reply.
--