Re: [PATCH 1/1] x86/vdso: add -Iarch/x86/include/uapi into HOST_EXTRACFLAGS

Andy Lutomirski
2015-05-07T19:46:57Z

On Thu, May 7, 2015 at 9:58 AM, Oleg Nesterov <oleg@redhat.com> wrote:
> Change HOST_EXTRACFLAGS to include arch/x86/include/uapi along with
> include/uapi.
>
> This looks more consistent, and this fixes "make bzImage" on my old
> distro which doesn't have asm/bitsperlong.h in /usr/include/.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Fixed: 6f121e548f83 x86, vdso: Reimplement vdso.so preparation in build-time C
Acked-by: Andy Lutomirski <luto@kernel.org>

Ingo, despite Oleg's rather late discovery of this, it's a regression
fix. If you think it's appropriate for x86/urgent, please apply it.
Otherwise I'll queue it up.

--Andy

> ---
> arch/x86/vdso/Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile
> index 275a3a8..e970320 100644
> --- a/arch/x86/vdso/Makefile
> +++ b/arch/x86/vdso/Makefile
> @@ -51,7 +51,7 @@ VDSO_LDFLAGS_vdso.lds = -m64 -Wl,-soname=linux-vdso.so.1 \
> $(obj)/vdso64.so.dbg: $(src)/vdso.lds $(vobjs) FORCE
> $(call if_changed,vdso)
>
> -HOST_EXTRACFLAGS += -I$(srctree)/tools/include -I$(srctree)/include/uapi
> +HOST_EXTRACFLAGS += -I$(srctree)/tools/include -I$(srctree)/include/uapi -I$(srctree)/arch/x86/include/uapi
> hostprogs-y += vdso2c
>
> quiet_cmd_vdso2c = VDSO2C $@
> --
> 1.5.5.1
>
>

--
Andy Lutomirski
AMA Capital Management, LLC