Re: [PATCH] x86, cpuinfo x86_model_id whitespace cleanup

Andy Lutomirski
2015-05-19T20:16:46Z

On Tue, May 19, 2015 at 12:22 PM, Borislav Petkov <bp@alien8.de> wrote:
> On Tue, May 19, 2015 at 11:44:41AM -0700, Andy Lutomirski wrote:
>> On May 19, 2015 11:13 AM, "Borislav Petkov" <bp@alien8.de> wrote:
>> >
>> > On Tue, May 19, 2015 at 01:25:59PM -0400, Brian Gerst wrote:
>> > > Using strlcpy in this manner could fail if it does larger than byte
>> > > copies and they overlap.
>> >
>> > Why?
>> >
>> > AFAICT, strlcpy() calls memcpy() and memcpy should handle overlapping
>> > buffers just fine.
>>
>> Are you thinking of memmove?
>
> I guess I'm trying to find out why don't we have a BIG FAT WARNING over
> memcpy saying not to use it with overlapping buffers and larger than
> byte sizes. Or maybe this is something everyone, except me, just knows
> and that's a "Doh, Boris, of course!".
>
> Btw, can we still avoid using the temporary buffer and use strncpy()
> instead? AFAICT, that does byte copies, from looking at the asm.

It's not just chunk size; it's the direction. If the dest starts
after the source but overlaps it and you copy forwards, then you can
clobber the end of the source before you read it. memmove is
specifically intended to avoid this.

Would it be possible to just use memmove directly?

--Andy