Re: [PATCH v5 2/6] x86/mm/pat: redefine pat_enabled

Luis R. Rodriguez
2015-05-05T00:42:35Z

On Mon, May 04, 2015 at 05:22:08PM +0200, Borislav Petkov wrote:
> On Thu, Apr 30, 2015 at 01:25:16PM -0700, Luis R. Rodriguez wrote:
> > diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c
> > index bfef424..f094d36 100644
> > --- a/arch/x86/kernel/cpu/mtrr/main.c
> > +++ b/arch/x86/kernel/cpu/mtrr/main.c
> > @@ -556,7 +556,7 @@ int arch_phys_wc_add(unsigned long base, unsigned long size)
> > {
> > int ret;
> >
> > - if (pat_enabled || !mtrr_enabled)
> > + if (pat_enabled() || !mtrr_enabled)
>
> What's going on here? I got a reject about mtrr_enabled which is nowhere
> to be found. Am I missing a patch?

Yes, the patch titled, "x86: mtrr: generalize run time disabling of MTRR"
should be applied first, or ammended to fit the new style. Let me know what
you prefer.

> Anyway, I applied that:

Great, thanks, is there a tree I can use to rebase / fetch ?

Luis