Re: [PATCH] mce: fix fail to set 'monarchtimeout' via boot option

Xie XiuQi
2015-05-21T01:00:20Z

On 2015/5/21 1:43, Borislav Petkov wrote:
> On Wed, May 20, 2015 at 07:22:23PM +0800, Xie XiuQi wrote:
>> I use "mce=1,10000000" in cmdline to change the monarch timeout, but
>> it does not work.
>>
>> The cause is that get_option() has parsed the ',' already, we need
>> not to check the ',' again.
>>
>> --
>> get_option(): read an int from an option string;
>> if available accept a subsequent comma as well.
>>
>> Return values:
>> 0 - no int in string
>> 1 - int found, no subsequent comma
>> 2 - int found including a subsequent comma
>> 3 - hyphen found to denote a range
>>
>> Cc: <stable@vger.kernel.org> # 2.6.32+
>
> I don't think that's a serious enough a bug to justify the stable tag.
>
>> Signed-off-by: Xie XiuQi <xiexiuqi@huawei.com>
>> ---

...

>> return 0;
>
> Anyway, I fixed it up and applied it.

Sorry, I will check carefully next time.

Thanks.

>
> Thanks.
>