From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mike Shuey <shuey@purdue.edu>
Cc: oleg.drokin@intel.com, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org, HPDD-discuss@ml01.01.org
Subject: Re: [PATCH] staging: lustre: code cleanup - variable declaration spacing
Date: Wed, 6 May 2015 16:52:35 +0300 [thread overview]
Message-ID: <20150506135235.GC14154@mwanda> (raw)
In-Reply-To: <1430913775-28350-1-git-send-email-shuey@purdue.edu>
On Wed, May 06, 2015 at 08:02:55AM -0400, Mike Shuey wrote:
> Clean up spacing in some variable declarations, to be more consistent.
>
> It's small, but I need to start somewhere. Please let me know if I'm not
> adhering to proper procedure for trivial cleanups.
Don't put these "aside" comments in the permanent kernel changelog.
Otherwise I like this patch, lining up the variables can look ok in
struct definitions in headers but in functions we can never keep it
consistent so it just looks whacky.
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-06 13:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 12:02 [PATCH] staging: lustre: code cleanup - variable declaration spacing Mike Shuey
2015-05-06 12:36 ` Sudip Mukherjee
2015-05-06 13:52 ` Dan Carpenter [this message]
[not found] ` <CABqvwjsia7nqfZtAP4T_DSKRTjdaNZa=7RxXJuZeVxHK7Y2z_Q@mail.gmail.com>
2015-05-06 15:05 ` Dan Carpenter
2015-05-07 3:36 ` [HPDD-discuss] " Dilger, Andreas
2015-05-07 12:09 ` Dan Carpenter
2015-05-07 15:32 ` Julia Lawall
2015-05-08 1:32 ` Drokin, Oleg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150506135235.GC14154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=shuey@purdue.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox