From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751567AbbEFNw5 (ORCPT ); Wed, 6 May 2015 09:52:57 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:34493 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865AbbEFNwx (ORCPT ); Wed, 6 May 2015 09:52:53 -0400 Date: Wed, 6 May 2015 16:52:35 +0300 From: Dan Carpenter To: Mike Shuey Cc: oleg.drokin@intel.com, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, HPDD-discuss@ml01.01.org Subject: Re: [PATCH] staging: lustre: code cleanup - variable declaration spacing Message-ID: <20150506135235.GC14154@mwanda> References: <1430913775-28350-1-git-send-email-shuey@purdue.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1430913775-28350-1-git-send-email-shuey@purdue.edu> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 06, 2015 at 08:02:55AM -0400, Mike Shuey wrote: > Clean up spacing in some variable declarations, to be more consistent. > > It's small, but I need to start somewhere. Please let me know if I'm not > adhering to proper procedure for trivial cleanups. Don't put these "aside" comments in the permanent kernel changelog. Otherwise I like this patch, lining up the variables can look ok in struct definitions in headers but in functions we can never keep it consistent so it just looks whacky. regards, dan carpenter