Re: [PATCH V2 1/6] x86/MCE/AMD: Factor out logging mechanism

Aravind Gopalakrishnan
2015-05-06T17:47:58Z

On 5/6/2015 12:41 PM, Borislav Petkov wrote:
>
> Yeah, let's save us the mce_setup() work in the !MCI_STATUS_VAL case:
>

Sure, thanks for fixing it.

> +static void __log_error(unsigned int bank, bool threshold_err, u64 misc)
> +{
> + struct mce m;
> + u64 status;
> +
> + rdmsrl(MSR_IA32_MCx_STATUS(bank), status);
> + if (!(status & MCI_STATUS_VAL))
> + return;
> +
> + mce_setup(&m);
> +
>

-Aravind.