From: Dan Carpenter <dan.carpenter@oracle.com>
To: Garret Kelly <gdk@google.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
"Noralf Trønnes" <noralf@tronnes.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: fbtft: force cast to non-__iomem pointer
Date: Thu, 7 May 2015 11:39:08 +0300 [thread overview]
Message-ID: <20150507083908.GF14154@mwanda> (raw)
In-Reply-To: <CAAUC4VKSAejfm35KDmed=2fXez8h+ZB3+thQr+yvVU4mu4g+og@mail.gmail.com>
On Wed, May 06, 2015 at 02:34:49PM -0700, Garret Kelly wrote:
> > Can't we fix this properly, to use the correct type of pointer instead
> > for non-__iomem allocations?
>
> You mean making an alternate screen_base pointer inside fb_info that
> isn't __iomem? There are already a bunch of framebuffer drivers that
> (ab)use screen_base to store non-__iomem pointers, so this didn't
> strike me as too far out of line.
You could add a new pointer or you could just make ->screen_base a
union. I'm not sure which is the best.
regards,
dan carpenter
prev parent reply other threads:[~2015-05-07 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 17:29 [PATCH] staging: fbtft: force cast to non-__iomem pointer Garret Kelly
2015-04-30 14:51 ` Greg Kroah-Hartman
2015-05-06 21:34 ` Garret Kelly
2015-05-07 8:39 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150507083908.GF14154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gdk@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox