From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751112AbbEGIjb (ORCPT ); Thu, 7 May 2015 04:39:31 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:41061 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbbEGIj2 (ORCPT ); Thu, 7 May 2015 04:39:28 -0400 Date: Thu, 7 May 2015 11:39:08 +0300 From: Dan Carpenter To: Garret Kelly Cc: Greg Kroah-Hartman , "open list:STAGING SUBSYSTEM" , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , open list Subject: Re: [PATCH] staging: fbtft: force cast to non-__iomem pointer Message-ID: <20150507083908.GF14154@mwanda> References: <1429205359-12929-1-git-send-email-gdk@google.com> <20150430145103.GA18896@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 06, 2015 at 02:34:49PM -0700, Garret Kelly wrote: > > Can't we fix this properly, to use the correct type of pointer instead > > for non-__iomem allocations? > > You mean making an alternate screen_base pointer inside fb_info that > isn't __iomem? There are already a bunch of framebuffer drivers that > (ab)use screen_base to store non-__iomem pointers, so this didn't > strike me as too far out of line. You could add a new pointer or you could just make ->screen_base a union. I'm not sure which is the best. regards, dan carpenter