From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Joe Perches <joe@perches.com>
Cc: Eddie Huang <eddie.huang@mediatek.com>,
Lee Jones <lee.jones@linaro.org>,
Alessandro Zummo <a.zummo@towertech.it>,
srv_heupstream@mediatek.com, Samuel Ortiz <sameo@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
"David S. Miller" <davem@davemloft.net>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Sascha Hauer <kernel@pengutronix.de>,
Tomasz Figa <tfiga@google.com>,
Tianping Fang <tianping.fang@mediatek.com>
Subject: Re: [PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver
Date: Thu, 7 May 2015 14:06:01 +0200 [thread overview]
Message-ID: <20150507120601.GH3465@piout.net> (raw)
In-Reply-To: <1430898299.9365.74.camel@perches.com>
On 06/05/2015 at 00:44:59 -0700, Joe Perches wrote :
> On Wed, 2015-05-06 at 15:23 +0800, Eddie Huang wrote:
> > From: Tianping Fang <tianping.fang@mediatek.com>
>
> trivia: no need to resend now, maybe in a future patch.
>
> > diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> []
> > +static int mtk_rtc_probe(struct platform_device *pdev)
> > +{
> []
> > + ret = request_threaded_irq(rtc->irq, NULL,
> > + mtk_rtc_irq_handler_thread,
> > + IRQF_ONESHOT | IRQF_TRIGGER_HIGH,
> > + "mt6397-rtc", rtc);
>
> It'd be nicer to align all the statement lines
> to that open parenthesis
>
>
I'll fix it up when applying.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-05-07 12:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 7:23 [PATCH v4 0/3] Add Mediatek SoC RTC driver Eddie Huang
2015-05-06 7:23 ` [PATCH v4 1/3] mfd: provide RTC resource in MT6397 MFD Eddie Huang
2015-05-06 7:23 ` [PATCH v4 2/3] rtc: mediatek: Add MT6397 RTC driver Eddie Huang
2015-05-06 7:44 ` Joe Perches
2015-05-07 12:06 ` Alexandre Belloni [this message]
2015-05-07 15:06 ` Eddie Huang
2015-05-06 7:23 ` [PATCH v4 3/3] MAINTAINERS: add Mediatek " Eddie Huang
2015-05-09 13:08 ` [PATCH v4 0/3] Add Mediatek SoC " Alexandre Belloni
2015-05-12 8:15 ` Daniel Kurtz
2015-05-12 8:41 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150507120601.GH3465@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=eddie.huang@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=kernel@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@osg.samsung.com \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@google.com \
--cc=tianping.fang@mediatek.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox