* [PATCH] tools/thermal: tmon: fixed the 'make install' command
@ 2015-05-07 18:09 Anand Moon
2015-05-07 20:31 ` Jacob Pan
0 siblings, 1 reply; 3+ messages in thread
From: Anand Moon @ 2015-05-07 18:09 UTC (permalink / raw)
To: Jacob Pan, Zhang Rui, Brian Norris, Florian Fainelli, Javi Merino,
Anand Moon
Cc: linux-kernel
To install tmon we issue "make install" which produces bellow error.
root@odroidxu3:/usr/src/odroidxu3-4.y-testing/tools/thermal/tmon# make install
mkdir -p /usr/bin
install -m 755 -p "tmon" "/usr/bin/tmon"
mkdir -p /
install -m 644 -p "" "/"
install: cannot stat ‘’: No such file or directory
make: [install] Error 1 (ignored)
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
tools/thermal/tmon/Makefile | 8 --------
1 file changed, 8 deletions(-)
diff --git a/tools/thermal/tmon/Makefile b/tools/thermal/tmon/Makefile
index 0788621..2e83dd3 100644
--- a/tools/thermal/tmon/Makefile
+++ b/tools/thermal/tmon/Makefile
@@ -12,10 +12,6 @@ TARGET=tmon
INSTALL_PROGRAM=install -m 755 -p
DEL_FILE=rm -f
-INSTALL_CONFIGFILE=install -m 644 -p
-CONFIG_FILE=
-CONFIG_PATH=
-
# Static builds might require -ltinfo, for instance
ifneq ($(findstring -static, $(LDFLAGS)),)
STATIC := --static
@@ -38,13 +34,9 @@ valgrind: tmon
install:
- mkdir -p $(INSTALL_ROOT)/$(BINDIR)
- $(INSTALL_PROGRAM) "$(TARGET)" "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
- - mkdir -p $(INSTALL_ROOT)/$(CONFIG_PATH)
- - $(INSTALL_CONFIGFILE) "$(CONFIG_FILE)" "$(INSTALL_ROOT)/$(CONFIG_PATH)"
uninstall:
$(DEL_FILE) "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
- $(CONFIG_FILE) "$(CONFIG_PATH)"
-
clean:
find . -name "*.o" | xargs $(DEL_FILE)
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/thermal: tmon: fixed the 'make install' command
2015-05-07 18:09 [PATCH] tools/thermal: tmon: fixed the 'make install' command Anand Moon
@ 2015-05-07 20:31 ` Jacob Pan
2015-05-08 3:04 ` Zhang Rui
0 siblings, 1 reply; 3+ messages in thread
From: Jacob Pan @ 2015-05-07 20:31 UTC (permalink / raw)
To: Anand Moon
Cc: Zhang Rui, Brian Norris, Florian Fainelli, Javi Merino,
linux-kernel
On Fri, 8 May 2015 03:39:04 +0930
Anand Moon <linux.amoon@gmail.com> wrote:
> To install tmon we issue "make install" which produces bellow error.
>
looks good, there is no config file for now.
Thanks for the fix.
Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
> root@odroidxu3:/usr/src/odroidxu3-4.y-testing/tools/thermal/tmon#
> make install mkdir -p /usr/bin
> install -m 755 -p "tmon" "/usr/bin/tmon"
> mkdir -p /
> install -m 644 -p "" "/"
> install: cannot stat ‘’: No such file or directory
> make: [install] Error 1 (ignored)
>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> tools/thermal/tmon/Makefile | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/tools/thermal/tmon/Makefile b/tools/thermal/tmon/Makefile
> index 0788621..2e83dd3 100644
> --- a/tools/thermal/tmon/Makefile
> +++ b/tools/thermal/tmon/Makefile
> @@ -12,10 +12,6 @@ TARGET=tmon
> INSTALL_PROGRAM=install -m 755 -p
> DEL_FILE=rm -f
>
> -INSTALL_CONFIGFILE=install -m 644 -p
> -CONFIG_FILE=
> -CONFIG_PATH=
> -
> # Static builds might require -ltinfo, for instance
> ifneq ($(findstring -static, $(LDFLAGS)),)
> STATIC := --static
> @@ -38,13 +34,9 @@ valgrind: tmon
> install:
> - mkdir -p $(INSTALL_ROOT)/$(BINDIR)
> - $(INSTALL_PROGRAM) "$(TARGET)"
> "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
> - - mkdir -p $(INSTALL_ROOT)/$(CONFIG_PATH)
> - - $(INSTALL_CONFIGFILE) "$(CONFIG_FILE)"
> "$(INSTALL_ROOT)/$(CONFIG_PATH)"
> uninstall:
> $(DEL_FILE) "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
> - $(CONFIG_FILE) "$(CONFIG_PATH)"
> -
>
> clean:
> find . -name "*.o" | xargs $(DEL_FILE)
[Jacob Pan]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/thermal: tmon: fixed the 'make install' command
2015-05-07 20:31 ` Jacob Pan
@ 2015-05-08 3:04 ` Zhang Rui
0 siblings, 0 replies; 3+ messages in thread
From: Zhang Rui @ 2015-05-08 3:04 UTC (permalink / raw)
To: Jacob Pan
Cc: Anand Moon, Brian Norris, Florian Fainelli, Javi Merino,
linux-kernel
On Thu, 2015-05-07 at 13:31 -0700, Jacob Pan wrote:
> On Fri, 8 May 2015 03:39:04 +0930
> Anand Moon <linux.amoon@gmail.com> wrote:
>
> > To install tmon we issue "make install" which produces bellow error.
> >
> looks good, there is no config file for now.
>
> Thanks for the fix.
> Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
>
patch applied. Thanks!
BTW, next time when sending a thermal related change, please cc
linux-pm@vger.kernel.org, or else the change may got because we usually
rely on https://patchwork.kernel.org/project/linux-pm/list/ to review
and scrub the patches. :)
thanks,
rui
> > root@odroidxu3:/usr/src/odroidxu3-4.y-testing/tools/thermal/tmon#
> > make install mkdir -p /usr/bin
> > install -m 755 -p "tmon" "/usr/bin/tmon"
> > mkdir -p /
> > install -m 644 -p "" "/"
> > install: cannot stat ‘’: No such file or directory
> > make: [install] Error 1 (ignored)
> >
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> > ---
> > tools/thermal/tmon/Makefile | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/tools/thermal/tmon/Makefile b/tools/thermal/tmon/Makefile
> > index 0788621..2e83dd3 100644
> > --- a/tools/thermal/tmon/Makefile
> > +++ b/tools/thermal/tmon/Makefile
> > @@ -12,10 +12,6 @@ TARGET=tmon
> > INSTALL_PROGRAM=install -m 755 -p
> > DEL_FILE=rm -f
> >
> > -INSTALL_CONFIGFILE=install -m 644 -p
> > -CONFIG_FILE=
> > -CONFIG_PATH=
> > -
> > # Static builds might require -ltinfo, for instance
> > ifneq ($(findstring -static, $(LDFLAGS)),)
> > STATIC := --static
> > @@ -38,13 +34,9 @@ valgrind: tmon
> > install:
> > - mkdir -p $(INSTALL_ROOT)/$(BINDIR)
> > - $(INSTALL_PROGRAM) "$(TARGET)"
> > "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
> > - - mkdir -p $(INSTALL_ROOT)/$(CONFIG_PATH)
> > - - $(INSTALL_CONFIGFILE) "$(CONFIG_FILE)"
> > "$(INSTALL_ROOT)/$(CONFIG_PATH)"
> > uninstall:
> > $(DEL_FILE) "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
> > - $(CONFIG_FILE) "$(CONFIG_PATH)"
> > -
> >
> > clean:
> > find . -name "*.o" | xargs $(DEL_FILE)
>
> [Jacob Pan]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-08 3:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-07 18:09 [PATCH] tools/thermal: tmon: fixed the 'make install' command Anand Moon
2015-05-07 20:31 ` Jacob Pan
2015-05-08 3:04 ` Zhang Rui
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox