From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751739AbbEGUby (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 May 2015 16:31:54 -0400
Received: from mga11.intel.com ([192.55.52.93]:22599 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751040AbbEGUbx convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 May 2015 16:31:53 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,384,1427785200"; 
   d="scan'208";a="490750595"
Date: Thu, 7 May 2015 13:31:45 -0700
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Anand Moon <linux.amoon@gmail.com>
Cc: Zhang Rui <rui.zhang@intel.com>,
        Brian Norris <computersforpeace@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Javi Merino <javi.merino@arm.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/thermal: tmon: fixed the 'make install' command
Message-ID: <20150507133145.66079d01@jacob-VirtualBox>
In-Reply-To: <1431022144-5173-1-git-send-email-linux.amoon@gmail.com>
References: <1431022144-5173-1-git-send-email-linux.amoon@gmail.com>
Organization: OTC
X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri,  8 May 2015 03:39:04 +0930
Anand Moon <linux.amoon@gmail.com> wrote:

> To install tmon we issue "make install" which produces bellow error.
> 
looks good, there is no config file for now.

Thanks for the fix.
Acked-by: Jacob Pan <jacob.jun.pan@linux.intel.com>

> root@odroidxu3:/usr/src/odroidxu3-4.y-testing/tools/thermal/tmon#
> make install mkdir -p /usr/bin
> install -m 755 -p "tmon" "/usr/bin/tmon"
> mkdir -p /
> install -m 644 -p "" "/"
> install: cannot stat ‘’: No such file or directory
> make: [install] Error 1 (ignored)
> 
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
>  tools/thermal/tmon/Makefile | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/tools/thermal/tmon/Makefile b/tools/thermal/tmon/Makefile
> index 0788621..2e83dd3 100644
> --- a/tools/thermal/tmon/Makefile
> +++ b/tools/thermal/tmon/Makefile
> @@ -12,10 +12,6 @@ TARGET=tmon
>  INSTALL_PROGRAM=install -m 755 -p
>  DEL_FILE=rm -f
>  
> -INSTALL_CONFIGFILE=install -m 644 -p
> -CONFIG_FILE=
> -CONFIG_PATH=
> -
>  # Static builds might require -ltinfo, for instance
>  ifneq ($(findstring -static, $(LDFLAGS)),)
>  STATIC := --static
> @@ -38,13 +34,9 @@ valgrind: tmon
>  install:
>  	- mkdir -p $(INSTALL_ROOT)/$(BINDIR)
>  	- $(INSTALL_PROGRAM) "$(TARGET)"
> "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
> -	- mkdir -p $(INSTALL_ROOT)/$(CONFIG_PATH)
> -	- $(INSTALL_CONFIGFILE) "$(CONFIG_FILE)"
> "$(INSTALL_ROOT)/$(CONFIG_PATH)" 
>  uninstall:
>  	$(DEL_FILE) "$(INSTALL_ROOT)/$(BINDIR)/$(TARGET)"
> -	$(CONFIG_FILE) "$(CONFIG_PATH)"
> -
>  
>  clean:
>  	find . -name "*.o" | xargs $(DEL_FILE)

[Jacob Pan]