From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751968AbbEGTU3 (ORCPT ); Thu, 7 May 2015 15:20:29 -0400 Received: from mail-ie0-f173.google.com ([209.85.223.173]:34700 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbbEGTUU (ORCPT ); Thu, 7 May 2015 15:20:20 -0400 Date: Thu, 7 May 2015 14:20:19 -0500 From: Michael Welling To: Mark Brown Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] spi: omap2-mcspi: Add support for GPIO chipselects Message-ID: <20150507192019.GA15112@deathray> References: <1430955472-11409-1-git-send-email-mwelling@ieee.org> <20150507185831.GQ22845@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150507185831.GQ22845@sirena.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 07, 2015 at 07:58:31PM +0100, Mark Brown wrote: > On Wed, May 06, 2015 at 06:37:52PM -0500, Michael Welling wrote: > > This patch allows for GPIOs specified in the devicetree to be used as SPI > > chipselects on TI OMAP2 SoCs. > > > > Tested on the AM3354. > > > > Signed-off-by: Michael Welling > > --- > > v3: Switches driver to use transfer_one instead of transfer_one_message > > allowing the spi core to handle toggling GPIO chip selects if specified. > > This is now two changes so it should be two patches, one converting to > transfer_one() and another adding the GPIO chip select support. This > makes things easier to review and helps people trying to understand the > git history in the future (right now there's not even a mention of the > conversion to transfer_one() in the changelog). Okay. I will break it down into a patch series. Do you have any other suggestions or comments on the patch so that I can incorporate those changes as well in the patch series? I noticed a few oddities in the code when converting. For instance: http://lxr.free-electrons.com/source/drivers/spi/spi-omap2-mcspi.c#L1225 What is the point of trying to print tx or rx given the if statement insures that rx_buff and tx_buff are NULL?