From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752049AbbEGTVs (ORCPT ); Thu, 7 May 2015 15:21:48 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:33763 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751367AbbEGTVo (ORCPT ); Thu, 7 May 2015 15:21:44 -0400 Date: Thu, 7 May 2015 20:21:39 +0100 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@stlinux.com, rtc-linux@googlegroups.com, a.zummo@towertech.it, daniel.lezcano@linaro.org, wim@iguana.be, tglx@linutronix.de, linux@roeck-us.net, linux-watchdog@vger.kernel.org Subject: Re: [STLinux Kernel] [PATCH 08/12] rtc: bindings: Supply knowledge of a third supported device - clocksource Message-ID: <20150507192139.GE16220@x1> References: <1431005924-21777-1-git-send-email-lee.jones@linaro.org> <1431005924-21777-9-git-send-email-lee.jones@linaro.org> <20150507141245.GA9793@griffinp-ThinkPad-X1-Carbon-2nd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20150507141245.GA9793@griffinp-ThinkPad-X1-Carbon-2nd> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > Documentation/devicetree/bindings/rtc/rtc-st-lpc.txt | 15 +++++++++------ > > 1 file changed, 9 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/rtc/rtc-st-lpc.txt b/Documentation/devicetree/bindings/rtc/rtc-st-lpc.txt > > index 73407f50..daf8826 100644 > > --- a/Documentation/devicetree/bindings/rtc/rtc-st-lpc.txt > > +++ b/Documentation/devicetree/bindings/rtc/rtc-st-lpc.txt > > @@ -1,20 +1,23 @@ > > STMicroelectronics Low Power Controller (LPC) - RTC > > =================================================== > > > > -LPC currently supports Watchdog OR Real Time Clock functionality. > > +LPC currently supports Watchdog OR Real Time Clock OR Clocksource > > +functionality. > > > > [See: ../watchdog/st_lpc_wdt.txt for Watchdog options] > > +[See: ../timer/st,stih407-lpc for Clocksource options] > > > > Required properties > > > > -- compatible : Must be one of: "st,stih407-lpc" "st,stih416-lpc" > > - "st,stih415-lpc" "st,stid127-lpc" > > +- compatible : Must be: "st,stih407-lpc" > > You are removing the compatibles documentation for the other supported SoC's like > stih416-lpc stih415-lpc here. It would be pretty difficult to do that by mistake. :) See the comment I made to the Watchdog bindings patch for more info. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog