From: Dan Carpenter <dan.carpenter@oracle.com>
To: German Rivera <German.Rivera@freescale.com>
Cc: devel@driverdev.osuosl.org, agraf@suse.de, arnd@arndb.de,
bhupesh.sharma@freescale.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, stuart.yoder@freescale.com,
scottwood@freescale.com, nir.erez@freescale.com,
itai.katz@freescale.com, bhamciu1@freescale.com,
R89243@freescale.com, richard.schmitt@freescale.com
Subject: Re: [PATCH v2 1/7] staging: fsl-mc: MC bus IRQ support
Date: Thu, 7 May 2015 23:01:19 +0300 [thread overview]
Message-ID: <20150507200118.GK14154@mwanda> (raw)
In-Reply-To: <554B7BF7.8030901@freescale.com>
On Thu, May 07, 2015 at 09:51:35AM -0500, German Rivera wrote:
> I'll remove the nested #ifdef. However, as I explained before, these
> #ifdefs are needed to be able to make the code compile without the
> GIC-ITS support in place. Of course, the code will not be moved out
> of staging with these #ifdefs. There is already an item for this in
> the drivers/staging/fsl-mc/TODO file.
Heh. This is a sort of amusing miscommunication.
I'm saying delete the dead code inside the ifdefs as well. Obviously
don't send code that can't compile. :P Btw, it's really easy to
commit parts of a file in git citool. Just highlight, right click and
select "add lines to commit".
Although if Greg wants to allow these ifdefs in, then my feelings will
not be hurt and I am fine with that.
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-07 20:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-06 21:28 [PATCH v2 0/7] staging: fsl-mc: New functionality to the MC bus driver J. German Rivera
2015-05-06 21:28 ` [PATCH v2 1/7] staging: fsl-mc: MC bus IRQ support J. German Rivera
2015-05-07 13:03 ` Dan Carpenter
2015-05-07 14:51 ` German Rivera
2015-05-07 20:01 ` Dan Carpenter [this message]
2015-05-10 13:14 ` Greg KH
2015-05-07 13:58 ` Dan Carpenter
2015-05-06 21:28 ` [PATCH v2 2/7] staging: fsl_-mc: add device binding path 'driver_override' J. German Rivera
2015-05-10 13:16 ` Greg KH
2015-05-06 21:28 ` [PATCH v2 3/7] staging: fsl-mc: Propagate driver_override for a child DPRC's children J. German Rivera
2015-05-06 21:28 ` [PATCH v2 4/7] staging: fsl-mc: Upgraded MC bus driver to match MC fw 7.0.0 J. German Rivera
2015-05-08 7:22 ` Dan Carpenter
2015-05-06 21:28 ` [PATCH v2 5/7] staging: fsl-mc: Allow the MC bus driver to run without GIC support J. German Rivera
2015-05-06 21:28 ` [PATCH v2 6/7] staging: fsl-mc: Add locking to serialize mc_send_command() calls J. German Rivera
2015-05-06 21:28 ` [PATCH v2 7/7] staging: fsl-mc: Use DPMCP IRQ and completion var to wait for MC J. German Rivera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150507200118.GK14154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=German.Rivera@freescale.com \
--cc=R89243@freescale.com \
--cc=agraf@suse.de \
--cc=arnd@arndb.de \
--cc=bhamciu1@freescale.com \
--cc=bhupesh.sharma@freescale.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=itai.katz@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nir.erez@freescale.com \
--cc=richard.schmitt@freescale.com \
--cc=scottwood@freescale.com \
--cc=stuart.yoder@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox