From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752546AbbEHHTk (ORCPT ); Fri, 8 May 2015 03:19:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49816 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751493AbbEHHTg (ORCPT ); Fri, 8 May 2015 03:19:36 -0400 Date: Fri, 8 May 2015 09:19:31 +0200 From: Greg Kroah-Hartman To: Sudip Mukherjee Cc: devel@driverdev.osuosl.org, Benjamin Romer , linux-kernel@vger.kernel.org, sparmaintainer@unisys.com Subject: Re: [PATCH 2/2] staging: unisys: remove unused variable Message-ID: <20150508071931.GA21996@kroah.com> References: <1430991412-5753-1-git-send-email-sudipm.mukherjee@gmail.com> <1430991412-5753-2-git-send-email-sudipm.mukherjee@gmail.com> <20150507200432.GB27787@kroah.com> <20150508042444.GA3192@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150508042444.GA3192@sudip-PC> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2015 at 09:54:44AM +0530, Sudip Mukherjee wrote: > On Thu, May 07, 2015 at 10:04:32PM +0200, Greg Kroah-Hartman wrote: > > On Thu, May 07, 2015 at 03:06:52PM +0530, Sudip Mukherjee wrote: > > > the previous patch of the series made this variable unused. > > > > What do you mean? There was only one other patch in this series, never > > send a patch that causes a build warning. > This patch is 2/2 , the 1/2 patch when applied will cause a build > warning about unused variable. > > should i then send a v2 mentioning that "1/2 will cause a build warning > which is fixed in 2/2" ? No, you fix 1/2 to not create a build warning.