From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752688AbbEHJEV (ORCPT <rfc822;w@1wt.eu>);
	Fri, 8 May 2015 05:04:21 -0400
Received: from aserp1040.oracle.com ([141.146.126.69]:34635 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750986AbbEHJES (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 8 May 2015 05:04:18 -0400
Date: Fri, 8 May 2015 12:04:02 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: devel@driverdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Benjamin Romer <benjamin.romer@unisys.com>, sparmaintainer@unisys.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] staging: unisys: remove unused variable
Message-ID: <20150508090402.GR14154@mwanda>
References: <1430991412-5753-1-git-send-email-sudipm.mukherjee@gmail.com>
 <1430991412-5753-2-git-send-email-sudipm.mukherjee@gmail.com>
 <20150507200432.GB27787@kroah.com>
 <20150508042444.GA3192@sudip-PC>
 <20150508073449.GM14154@mwanda>
 <20150508075413.GA7663@sudip-PC>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150508075413.GA7663@sudip-PC>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 08, 2015 at 01:24:32PM +0530, Sudip Mukherjee wrote:

> so, what i understood till now:
> 1) any patch of the series should not break the build.
> 	(you told me that in my parport patch series :) )
> 
> 2) any patch of the series should not introduce build warning.
> 
> 3) when i am modifying some line, i can make simple changes in style.
> 	but if its big change in style then that should be a separate
> 	patch.
> 

Yes.

regards,
carpenter