From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752940AbbEHLAR (ORCPT ); Fri, 8 May 2015 07:00:17 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:38509 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752544AbbEHLAN (ORCPT ); Fri, 8 May 2015 07:00:13 -0400 Date: Fri, 8 May 2015 12:59:58 +0200 From: Peter Zijlstra To: Andi Kleen Cc: kan.liang@intel.com, eranian@google.com, acme@infradead.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH 2/9] x86, perf: Add support for PEBSv3 profiling Message-ID: <20150508105958.GD27504@twins.programming.kicks-ass.net> References: <1431039392-12589-1-git-send-email-andi@firstfloor.org> <1431039392-12589-3-git-send-email-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431039392-12589-3-git-send-email-andi@firstfloor.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 07, 2015 at 03:56:25PM -0700, Andi Kleen wrote: > +/* Same as HSW, plus TSC */ > + > +struct pebs_record_v3 { This is inconsistently named. > + u64 flags, ip; > + u64 ax, bx, cx, dx; > + u64 si, di, bp, sp; > + u64 r8, r9, r10, r11; > + u64 r12, r13, r14, r15; > + u64 status, dla, dse, lat; > + u64 real_ip, tsx_tuning; > + u64 tsc; > +}; > @@ -958,6 +971,13 @@ static void __intel_pmu_pebs_event(struct perf_event *event, > data.txn = intel_hsw_transaction(pebs); > } > > + /* > + * v3 supplies an accurate time stamp, so we use that > + * for the time stamp. > + */ > + if (x86_pmu.intel_cap.pebs_format >= 3) > + data.time = native_sched_clock_from_tsc(pebs->tsc); That's wrong. It does not respect perf_event_attr::clock_id.