From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753685AbbEHRJX (ORCPT ); Fri, 8 May 2015 13:09:23 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:56623 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751508AbbEHRJV (ORCPT ); Fri, 8 May 2015 13:09:21 -0400 Date: Fri, 8 May 2015 18:09:16 +0100 From: Mark Brown To: Michael Welling Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20150508170916.GD2761@sirena.org.uk> References: <1431041814-24757-1-git-send-email-mwelling@ieee.org> <1431041814-24757-3-git-send-email-mwelling@ieee.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rqzD5py0kzyFAOWN" Content-Disposition: inline In-Reply-To: <1431041814-24757-3-git-send-email-mwelling@ieee.org> X-Cookie: 13. ... r-q1 User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v4 2/2] spi: omap2-mcspi: Add gpio_request and init CS X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --rqzD5py0kzyFAOWN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, May 07, 2015 at 06:36:54PM -0500, Michael Welling wrote: > + if (gpio_is_valid(spi->cs_gpio)) { > + if (gpio_request(spi->cs_gpio, dev_name(&spi->dev)) == 0) > + gpio_direction_output(spi->cs_gpio, > + !(spi->mode & SPI_CS_HIGH)); > + } I'm not seeing anything that frees this GPIO? --rqzD5py0kzyFAOWN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVTO27AAoJECTWi3JdVIfQ+yMH/imw2dB9l0bpE6CO953PGZIw zwtvwrcmYPhsY4KNCAUuHYUl3OYUYMVm3qOnzHLXkR2Yol3vJPA4qSSqiDNPJOi5 FSPZIplGEOHEFCzR8Fn167MbYwOTMA3AG/0uH+SJhMeaHnCg5/3NxPka0+2js0JY e5FWkGSKn5Yyn9Oto0KAzym3uEpu7OdZdG1kd+5bF5GuoxtmbVtLirdWnsMy0kuo qzhRJ7osGiTcjgUq1Z6eqkJtbuXcs+TKnJqw3bxnAyYk93DoeiXn2fM9Z0AZekFP SGeycdNQQRFZjujqwRG7wxp0l7QnY5/vOkxTIwxcC/Gylc6JFBIldnSvJwyyr+E= =GzPy -----END PGP SIGNATURE----- --rqzD5py0kzyFAOWN--