public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH] perf build: Disable libdw DWARF unwind when built with NO_DWARF
Date: Fri, 8 May 2015 16:44:04 -0300	[thread overview]
Message-ID: <20150508194404.GS7862@kernel.org> (raw)
In-Reply-To: <1430306131-6780-1-git-send-email-naveen.n.rao@linux.vnet.ibm.com>

Em Wed, Apr 29, 2015 at 04:45:31PM +0530, Naveen N. Rao escreveu:
> We get a linker error if we try to build with NO_DWARF since we build
> util/unwind-libdw.c, but do not include -ldw

Thanks, applied, but adding Jiri to the CC list, lets see if he pokes
some hole on this one...

- Arnaldo
 
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> ---
>  tools/perf/config/Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/perf/config/Makefile b/tools/perf/config/Makefile
> index 59a98c6..d47c4dc 100644
> --- a/tools/perf/config/Makefile
> +++ b/tools/perf/config/Makefile
> @@ -268,6 +268,10 @@ else
>    endif # libelf support
>  endif # NO_LIBELF
>  
> +ifdef NO_DWARF
> +  NO_LIBDW_DWARF_UNWIND := 1
> +endif
> +
>  ifndef NO_LIBELF
>    CFLAGS += -DHAVE_LIBELF_SUPPORT
>    EXTLIBS += -lelf
> -- 
> 2.3.5

  reply	other threads:[~2015-05-08 19:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-29 11:15 [PATCH] perf build: Disable libdw DWARF unwind when built with NO_DWARF Naveen N. Rao
2015-05-08 19:44 ` Arnaldo Carvalho de Melo [this message]
2015-05-11 13:36   ` Jiri Olsa
2015-05-11 14:01     ` Arnaldo Carvalho de Melo
2015-05-11 16:03       ` Naveen N. Rao
2015-05-10  7:12 ` [tip:perf/core] " tip-bot for Naveen N. Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150508194404.GS7862@kernel.org \
    --to=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=naveen.n.rao@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox