From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jaime Arrocha <jarr@kerneldev.net>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
deanahn@gctsemi.com, jonathankim@gctsemi.com,
linux-kernel@vger.kernel.org, jarrocha@linux.com
Subject: Re: [PATCH] staging: gdm724: adding kernel endianness header
Date: Sat, 9 May 2015 13:59:40 +0300 [thread overview]
Message-ID: <20150509105940.GE14154@mwanda> (raw)
In-Reply-To: <20150508232924.GA30574@localhost.localdomain>
On Fri, May 08, 2015 at 06:29:24PM -0500, Jaime Arrocha wrote:
> >From TODO list: remove test for host endian
> Included header to gather information about host endianness.
> Please let me know if the code addition requires corrections
> to meet standards.
>
No. This isn't really an improvement. We need to get rid of ->host_ed
entirely. Which is actually easy. Basically change gdm_cpu_to_dev16()
and friends to do so something:
u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x)
{
if (ed->dev_ed == ENDIANNESS_LITTLE)
return cpu_to_le16(x);
else
return cpu_to_be16(x);
}
regards,
dan carpenter
next prev parent reply other threads:[~2015-05-09 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 23:29 [PATCH] staging: gdm724: adding kernel endianness header Jaime Arrocha
2015-05-09 10:59 ` Dan Carpenter [this message]
2015-05-09 16:55 ` Jaime Arrocha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150509105940.GE14154@mwanda \
--to=dan.carpenter@oracle.com \
--cc=deanahn@gctsemi.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jarr@kerneldev.net \
--cc=jarrocha@linux.com \
--cc=jonathankim@gctsemi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox