From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753681AbbEIK75 (ORCPT <rfc822;w@1wt.eu>);
	Sat, 9 May 2015 06:59:57 -0400
Received: from userp1040.oracle.com ([156.151.31.81]:18839 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753307AbbEIK74 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 9 May 2015 06:59:56 -0400
Date: Sat, 9 May 2015 13:59:40 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jaime Arrocha <jarr@kerneldev.net>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        deanahn@gctsemi.com, jonathankim@gctsemi.com,
        linux-kernel@vger.kernel.org, jarrocha@linux.com
Subject: Re: [PATCH] staging: gdm724: adding kernel endianness header
Message-ID: <20150509105940.GE14154@mwanda>
References: <20150508232924.GA30574@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150508232924.GA30574@localhost.localdomain>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Source-IP: userv0021.oracle.com [156.151.31.71]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, May 08, 2015 at 06:29:24PM -0500, Jaime Arrocha wrote:
> >From TODO list: remove test for host endian
> Included header to gather information about host endianness.
> Please let me know if the code addition requires corrections
> to meet standards.
> 

No.  This isn't really an improvement.  We need to get rid of ->host_ed
entirely.  Which is actually easy.  Basically change gdm_cpu_to_dev16()
and friends to do so something:

u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x)
{
	if (ed->dev_ed == ENDIANNESS_LITTLE)
		return cpu_to_le16(x);
	else
		return cpu_to_be16(x);
}

regards,
dan carpenter