* [PATCH] staging: unisys: Disable driver for UML
@ 2015-05-04 19:02 Richard Weinberger
2015-05-10 13:02 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2015-05-04 19:02 UTC (permalink / raw)
To: benjamin.romer, david.kershner
Cc: gregkh, sparmaintainer, devel, linux-kernel, Richard Weinberger
UML has no io memory nor cpuid.
Let's disable this driver for UML.
Fixes:
drivers/staging/unisys/common-spar/include/iovmcall_gnuc.h: In function ‘__unisys_vmcall_gnuc’:
drivers/staging/unisys/common-spar/include/iovmcall_gnuc.h:24:2: error: implicit declaration of function ‘cpuid’ [-Werror=implicit-function-declaration]
cpuid(0x00000001, &cpuid_eax, &cpuid_ebx, &cpuid_ecx, &cpuid_edx);
^
In file included from drivers/staging/unisys/uislib/uislib.c:33:0:
drivers/staging/unisys/include/uisutils.h: In function ‘dbg_ioremap_cache’:
drivers/staging/unisys/include/uisutils.h:78:2: error: implicit declaration of function ‘ioremap_cache’ [-Werror=implicit-function-declaration]
new = ioremap_cache(addr, size);
^
drivers/staging/unisys/include/uisutils.h:78:6: warning: assignment makes pointer from integer without a cast [enabled by default]
new = ioremap_cache(addr, size);
^
drivers/staging/unisys/include/uisutils.h: In function ‘dbg_ioremap’:
drivers/staging/unisys/include/uisutils.h:89:2: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
new = ioremap(addr, size);
^
drivers/staging/unisys/include/uisutils.h:89:6: warning: assignment makes pointer from integer without a cast [enabled by default]
new = ioremap(addr, size);
^
drivers/staging/unisys/include/uisutils.h: In function ‘dbg_iounmap’:
drivers/staging/unisys/include/uisutils.h:98:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
iounmap(addr);
Signed-off-by: Richard Weinberger <richard@nod.at>
---
drivers/staging/unisys/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/Kconfig b/drivers/staging/unisys/Kconfig
index 19fcb34..a6d6c2a 100644
--- a/drivers/staging/unisys/Kconfig
+++ b/drivers/staging/unisys/Kconfig
@@ -3,7 +3,7 @@
#
menuconfig UNISYSSPAR
bool "Unisys SPAR driver support"
- depends on X86_64
+ depends on X86_64 && !UML
---help---
Support for the Unisys SPAR drivers
--
1.8.4.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: unisys: Disable driver for UML
2015-05-04 19:02 [PATCH] staging: unisys: Disable driver for UML Richard Weinberger
@ 2015-05-10 13:02 ` Greg KH
2015-05-10 21:02 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2015-05-10 13:02 UTC (permalink / raw)
To: Richard Weinberger
Cc: benjamin.romer, david.kershner, devel, sparmaintainer,
linux-kernel
On Mon, May 04, 2015 at 09:02:10PM +0200, Richard Weinberger wrote:
> UML has no io memory nor cpuid.
> Let's disable this driver for UML.
Doesn't apply to my tree :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: unisys: Disable driver for UML
2015-05-10 13:02 ` Greg KH
@ 2015-05-10 21:02 ` Richard Weinberger
0 siblings, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2015-05-10 21:02 UTC (permalink / raw)
To: Greg KH; +Cc: benjamin.romer, david.kershner, devel, sparmaintainer,
linux-kernel
Am 10.05.2015 um 15:02 schrieb Greg KH:
> On Mon, May 04, 2015 at 09:02:10PM +0200, Richard Weinberger wrote:
>> UML has no io memory nor cpuid.
>> Let's disable this driver for UML.
>
> Doesn't apply to my tree :(
I'm sorry Greg, looks like my -next tree needs updating.
Will resend soon.
Thanks,
//richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-10 21:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-04 19:02 [PATCH] staging: unisys: Disable driver for UML Richard Weinberger
2015-05-10 13:02 ` Greg KH
2015-05-10 21:02 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox