From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751720AbbEJRRG (ORCPT ); Sun, 10 May 2015 13:17:06 -0400 Received: from mail.kernel.org ([198.145.29.136]:48751 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbbEJRRD (ORCPT ); Sun, 10 May 2015 13:17:03 -0400 Date: Sun, 10 May 2015 14:16:58 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH 2/3] perf report: Force tty output if -T/--thread option is given Message-ID: <20150510171658.GA4587@kernel.org> References: <1431184784-30525-1-git-send-email-namhyung@kernel.org> <1431184784-30525-2-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1431184784-30525-2-git-send-email-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sun, May 10, 2015 at 12:19:43AM +0900, Namhyung Kim escreveu: > The -T/--thread option is supported only on --stdio mode (at least for > now). So enforce the tty output if the option was requested. > > Signed-off-by: Namhyung Kim > --- > tools/perf/builtin-report.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > index b63aeda719be..ee541ad555f2 100644 > --- a/tools/perf/builtin-report.c > +++ b/tools/perf/builtin-report.c > @@ -803,8 +803,8 @@ repeat: > goto error; > } > > - /* Force tty output for header output. */ > - if (report.header || report.header_only) > + /* Force tty output for header output and per-thread stat. */ > + if (report.header || report.header_only || report.show_threads) > use_browser = 0; I will apply, but please consider sending a followup patch to emit a warning for the cases when --tui or --gtk is explicitely passed, i.e. emit a warning saying that that is not possible. - Arnaldo > > if (strcmp(input_name, "-") != 0) > -- > 2.3.7