Re: [RFC PATCH 21/22] perf bpf: probe at kprobe points.

Masami Hiramatsu
2015-05-05T16:34:26Z

At least we need a description what this patch does... what will be
done with this patch, and what the user will see and what/how they can do.

Thank you,

On 2015/04/30 19:52, Wang Nan wrote:
> ---
> tools/perf/util/bpf-loader.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/tools/perf/util/bpf-loader.c b/tools/perf/util/bpf-loader.c
> index 208f5e8..186a3d0 100644
> --- a/tools/perf/util/bpf-loader.c
> +++ b/tools/perf/util/bpf-loader.c
> @@ -952,8 +952,26 @@ out:
> return -1;
> }
>
> +static int bpf_probe(void)
> +{
> + int err = add_perf_probe_events(params.event_array,
> + params.nr_events,
> + MAX_PROBES, 0);
> + /* add_perf_probe_events return negative when fail */
> + if (err < 0)
> + pr_err("bpf probe: failed to probe events\n");
> +
> + return err < 0 ? err : 0;
> +}
> +
> int bpf__run(void)
> {
> + int err;
> +
> + pr_debug("bpf: probing\n");
> + if ((err = bpf_probe()))
> + return err;
> +
> pr_info("BPF is running. Use Ctrl-c to stop.\n");
> while(1)
> sleep(1);
>

--
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com