Re: [RFC PATCH 01/22] perf: probe: avoid segfault if passed with ''.

Arnaldo Carvalho de Melo
2015-05-05T16:10:15Z

Em Tue, May 05, 2015 at 11:09:21PM +0900, Masami Hiramatsu escreveu:
> On 2015/04/30 19:52, Wang Nan wrote:
> > Since parse_perf_probe_point() deals with a user passed argument, we
> > should not assume it to be a valid string.
> >
> > Without this patch, if pass '' to perf probe, a segfault raises:
> >
> > $ perf probe -a ''
> > Segmentation fault

> > This patch checks argument of parse_perf_probe_point() before
> > string processing.

> > After this patch:

> > $ perf probe -a ''
> >
> > usage: perf probe [<options>] 'PROBEDEF' ['PROBEDEF' ...]
> > or: perf probe [<options>] --add 'PROBEDEF' [--add 'PROBEDEF' ...]
> > ...

> This looks OK to me.

> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

> Could you split this as an independent bugfix with my ack?

You mean split from this patchkit? I already did that, added it to my
perf/urgent branch, where I'll add your acked-by as well,

- Arnaldo