From: Ingo Molnar <mingo@kernel.org>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, bp@suse.de, dave.hansen@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] mtrr:Remove unnessary included header for the file,main.c
Date: Mon, 11 May 2015 09:15:24 +0200 [thread overview]
Message-ID: <20150511071524.GA27464@gmail.com> (raw)
In-Reply-To: <1431259382-32732-1-git-send-email-xerofoify@gmail.com>
* Nicholas Krause <xerofoify@gmail.com> wrote:
> Removes the no longer needed include statement to include the
> header file,linux/types.h due to the header file,kvm_para.h
> no needing this secondary header in order to build successfully
> when being included in other files.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> arch/x86/kernel/cpu/mtrr/main.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c
> index ea5f363..049212e 100644
> --- a/arch/x86/kernel/cpu/mtrr/main.c
> +++ b/arch/x86/kernel/cpu/mtrr/main.c
> @@ -33,8 +33,6 @@
>
> #define DEBUG
>
> -#include <linux/types.h> /* FIXME: kvm_para.h needs this */
> -
> #include <linux/stop_machine.h>
> #include <linux/kvm_para.h>
> #include <linux/uaccess.h>
Please don't bother with such churn unless you do more substantial
work in this area.
Thanks,
Ingo
parent reply other threads:[~2015-05-11 7:15 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1431259382-32732-1-git-send-email-xerofoify@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511071524.GA27464@gmail.com \
--to=mingo@kernel.org \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox