From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org
Subject: Re: rtc: mc13xxx: fix obfuscated and wrong format string
Date: Mon, 11 May 2015 09:26:15 +0200 [thread overview]
Message-ID: <20150511072615.GK3338@piout.net> (raw)
In-Reply-To: <1424440050-32000-1-git-send-email-linux@rasmusvillemoes.dk>
On 20/02/2015 at 14:47:30 +0100, Rasmus Villemoes wrote :
> According to C99, %2.s means 'print two spaces' (a precision of
> . without following digits or * means 0). The kernel's printf
> implementation, however, treats that case as if no precision was
> given, but relying on that quirk is rather silly. Also, since no -
> (aka left-justify) flag is given, the field with of 2 would then cause
> the alarm->enabled case to come out as "o n". Deobfuscate it.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> drivers/rtc/rtc-mc13xxx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Rebased and applied on rtc-next, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2015-05-11 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 13:47 [PATCH] rtc: mc13xxx: fix obfuscated and wrong format string Rasmus Villemoes
2015-05-11 7:26 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511072615.GK3338@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox